Remove FIXME on ExtCtxt::fn_decl()
#97478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 643c508 has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 28, 2022
…-errors Remove FIXME on `ExtCtxt::fn_decl()` `ExtCtxt::fn_decl()` is used like `self.fn_decl(..)` or `self.cx.fn_decl(..)`, coverting it to an assoc fn, for example, makes it inconvenience (e.g. `self.cx.fn_decl(..)` would be longer to represent). Given that, it doesn't seem a "FIXME" thing and unused `self` is okay, I think.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 29, 2022
…laumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#96950 (Add regression test for rust-lang#96395) - rust-lang#97028 (Add support for embedding pretty printers via `#[debugger_visualizer]` attribute) - rust-lang#97478 (Remove FIXME on `ExtCtxt::fn_decl()`) - rust-lang#97479 (Make some tests check-pass) - rust-lang#97482 (ptr::invalid is not equivalent to a int2ptr cast) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExtCtxt::fn_decl()is used likeself.fn_decl(..)orself.cx.fn_decl(..), coverting it to an assoc fn, for example, makes it inconvenience (e.g.self.cx.fn_decl(..)would be longer to represent). Given that, it doesn't seem a "FIXME" thing and unusedselfis okay, I think.