Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #97622

Merged
merged 19 commits into from
Jun 1, 2022
Merged

Rollup of 9 pull requests #97622

merged 19 commits into from
Jun 1, 2022

Commits on May 20, 2022

  1. Configuration menu
    Copy the full SHA
    0b781b0 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2022

  1. Configuration menu
    Copy the full SHA
    1b4714f View commit details
    Browse the repository at this point in the history

Commits on May 27, 2022

  1. Configuration menu
    Copy the full SHA
    e4d48c3 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2022

  1. Configuration menu
    Copy the full SHA
    5d86305 View commit details
    Browse the repository at this point in the history
  2. Corrected EBNF grammar for from_str

    Previously, the `Number` part of the EBNF grammar had an option for `'.' Digit*`, which would include the string "." (a single decimal point). This is not valid, and does not return an Ok as stated. The corrected version removes this, and still allows for the `'.' Digit+` case with the already existing `Digit* '.' Digit+` case.
    ijchen authored May 28, 2022
    Configuration menu
    Copy the full SHA
    0484cfb View commit details
    Browse the repository at this point in the history

Commits on May 31, 2022

  1. Configuration menu
    Copy the full SHA
    c00d9bf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0a6001b View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. Tweak insert docs

    azdavis committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    b02146a View commit details
    Browse the repository at this point in the history
  2. remove an unnecessary Option

    TaKO8Ki committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    8d007aa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ea50d77 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#94647 - Urgau:hash-map-many-mut, r=Amanieu

    Expose `get_many_mut` and `get_many_unchecked_mut` to HashMap
    
    This pull-request expose the function [`get_many_mut`](https://docs.rs/hashbrown/0.12.0/hashbrown/struct.HashMap.html#method.get_many_mut) and [`get_many_unchecked_mut`](https://docs.rs/hashbrown/0.12.0/hashbrown/struct.HashMap.html#method.get_many_unchecked_mut) from `hashbrown` to the standard library `HashMap` type. They obviously keep the same API and are added under the (new) `map_many_mut` feature.
    
    - `get_many_mut`: Attempts to get mutable references to `N` values in the map at once.
    - `get_many_unchecked_mut`: Attempts to get mutable references to `N` values in the map at once, without validating that the values are unique.
    JohnTitor authored Jun 1, 2022
    Configuration menu
    Copy the full SHA
    9ddae15 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#97216 - RalfJung:null-ptr-check, r=oli-obk

    Ensure we never consider the null pointer dereferencable
    
    This replaces the checks that are being removed in rust-lang#97188. Those checks were too early and hence incorrect.
    JohnTitor authored Jun 1, 2022
    Configuration menu
    Copy the full SHA
    2ab919a View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#97399 - SparrowLii:arg_index, r=oli-obk

    simplify code of finding arg index in `opt_const_param_of`
    
    From the FIXME in the impl of `opt_const_param_of`. Part of the code is simplified by blending two iterator statements and using `let...else` statement.
    JohnTitor authored Jun 1, 2022
    Configuration menu
    Copy the full SHA
    9c61f81 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#97470 - notriddle:notriddle/test-cases, r=G…

    …uillaumeGomez
    
    rustdoc: add more test coverage
    
    rust-lang#91113
    JohnTitor authored Jun 1, 2022
    Configuration menu
    Copy the full SHA
    a1dc541 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#97498 - ijchen:master, r=Mark-Simulacrum

    Corrected EBNF grammar for from_str
    
    Hello! This is my first time contributing to an open-source project. I'm excited to have the chance to contribute to the rust community 🥳
    
    I noticed an issue with the documentation for `from_str` in `f32` and `f64`. It states that "All strings that adhere to the following [EBNF](https://www.w3.org/TR/REC-xml/#sec-notation) grammar when lowercased will result in an `Ok` being returned. I believe this is incorrect for the string `"."`, which is valid for the given EBNF grammar, but does not result in an `Ok` being returned ([playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=09f891aa87963a56d3b0d715d8cbc2b4)). I have simplified the grammar in a way which fixes that, but is otherwise identical.
    
    Previously, the `Number` part of the EBNF grammar had an option for `'.' Digit*`, which would include the string `"."`. This is not valid, and does not return an Ok as stated. The corrected version removes this, and still allows for the `'.' Digit+` case with the already existing `Digit* '.' Digit+` case.
    JohnTitor authored Jun 1, 2022
    Configuration menu
    Copy the full SHA
    e1d2e65 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#97562 - compiler-errors:comment-poly_projec…

    …t_and_unify_type, r=lcnr
    
    Fix comment in `poly_project_and_unify_type`
    
    Renamed some variants to match `ProjectAndUnifyResult`
    JohnTitor authored Jun 1, 2022
    Configuration menu
    Copy the full SHA
    2f99f1b View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#97580 - JohnTitor:issue-71546, r=compiler-e…

    …rrors
    
    Add regression test for rust-lang#71546
    
    Closes rust-lang#71546
    r? `@compiler-errors`
    JohnTitor authored Jun 1, 2022
    Configuration menu
    Copy the full SHA
    a7bd0d0 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#97611 - azdavis:master, r=Dylan-DPC

    Tweak insert docs
    
    For `{Hash, BTree}Map::insert`, I always have to take a few extra seconds to think about the slight weirdness about the fact that if we "did not" insert (which "sounds" false), we return true, and if we "did" insert, (which "sounds" true), we return false.
    
    This tweaks the doc comments for the `insert` methods of those types (as well as what looks like a rustc internal data structure that I found just by searching the codebase for "If the set did") to first use the "Returns whether _something_" pattern used in e.g. `remove`, where we say that `remove` "returns whether the value was present".
    JohnTitor authored Jun 1, 2022
    Configuration menu
    Copy the full SHA
    2c3a8cf View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#97616 - TaKO8Ki:remove-unnecessary-option, …

    …r=Dylan-DPC
    
    Remove an unnecessary `Option`
    JohnTitor authored Jun 1, 2022
    Configuration menu
    Copy the full SHA
    85fdef0 View commit details
    Browse the repository at this point in the history