add cast kind of from_exposed_addr (int-to-ptr casts) #97653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
Some changes occured to rustc_codegen_cranelift cc @bjorn3 Some changes occurred in src/tools/clippy. cc @rust-lang/clippy Some changes occured to the CTFE / Miri engine cc @rust-lang/miri |
|
r? @wesleywiser (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
RalfJung
commented
Jun 2, 2022
| let ty_from = op.ty(body, tcx); | ||
| let cast_ty_from = CastTy::from_ty(ty_from); | ||
| let cast_ty_to = CastTy::from_ty(*ty); | ||
| // Misc casts are either between floats and ints, or one ptr type to another. |
There was a problem hiding this comment.
@oli-obk this looks like logic that would also be nice to have in MIR validation, but without duplicating everything...
There was a problem hiding this comment.
yea, I was actually wondering whether we shouldn't move (large) parts of mir typeck to mir validation
There was a problem hiding this comment.
basically anything that doesn't produce obligations I guess
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
RalfJung
commented
Jun 2, 2022
This comment has been minimized.
This comment has been minimized.
oli-obk
reviewed
Jun 2, 2022
|
📌 Commit d5a590f has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 3, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#97366 (Stabilize `{slice,array}::from_ref`) - rust-lang#97653 (add cast kind of from_exposed_addr (int-to-ptr casts)) - rust-lang#97663 (take back half-baked noaliasing check in Assignment) - rust-lang#97664 (On E0204 suggest missing type param bounds) - rust-lang#97668 (rustdoc: clean up primitive.slice.html links) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 4, 2022
add cast kind of from_exposed_addr (int-to-ptr casts) This is basically the dual to rust-lang#97582, for int2ptr casts. Cc `@tmiasko` rust-lang#97649
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically the dual to #97582, for int2ptr casts.
Cc @tmiasko #97649