Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Miri #97801

Merged
merged 1 commit into from
Jun 7, 2022
Merged

update Miri #97801

merged 1 commit into from
Jun 7, 2022

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jun 6, 2022

Fixes #97745
r? @ghost Cc @rust-lang/miri
Cc @InfRandomness

@RalfJung
Copy link
Member Author

RalfJung commented Jun 6, 2022

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jun 6, 2022

📌 Commit 2e4e340 has been approved by RalfJung

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 6, 2022
@bors
Copy link
Contributor

bors commented Jun 6, 2022

⌛ Testing commit 2e4e340 with merge 7f4f823a8f43c277f5d0d6a6e534b4c2bc758970...

@bors
Copy link
Contributor

bors commented Jun 6, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 6, 2022
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-mingw-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
test [rustdoc] src/test\rustdoc\wrapping.rs ... ok

failures:

---- [rustdoc] src/test\rustdoc\primitive\no_std.rs stdout ----
thread '[rustdoc] src/test\rustdoc\primitive\no_std.rs' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 5, kind: PermissionDenied, message: "Access is denied." }', src\tools\compiletest\src\runtest.rs:2283:34


failures:
    [rustdoc] src/test\rustdoc\primitive\no_std.rs
    [rustdoc] src/test\rustdoc\primitive\no_std.rs

Some tests failed in compiletest suite=rustdoc mode=rustdoc host=x86_64-pc-windows-gnu target=x86_64-pc-windows-gnu
test result: FAILED. 522 passed; 1 failed; 6 ignored; 0 measured; 0 filtered out; finished in 87.38s

Build completed unsuccessfully in 0:45:15
make: *** [Makefile:78: ci-mingw-subset-1] Error 1

@RalfJung
Copy link
Member Author

RalfJung commented Jun 6, 2022

Some rustdoc test failure...?

---- [rustdoc] src/test\rustdoc\primitive\no_std.rs stdout ----
thread '[rustdoc] src/test\rustdoc\primitive\no_std.rs' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 5, kind: PermissionDenied, message: "Access is denied." }', src\tools\compiletest\src\runtest.rs:2283:34
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
    [rustdoc] src/test\rustdoc\primitive\no_std.rs

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2022
@bors
Copy link
Contributor

bors commented Jun 7, 2022

⌛ Testing commit 2e4e340 with merge 9f7e997...

@bors
Copy link
Contributor

bors commented Jun 7, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 9f7e997 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 7, 2022
@bors bors merged commit 9f7e997 into rust-lang:master Jun 7, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 7, 2022
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #97801!

Tested on commit 9f7e997.
Direct link to PR: #97801

🎉 miri on windows: build-fail → test-pass (cc @RalfJung @oli-obk @eddyb).
🎉 miri on linux: build-fail → test-pass (cc @RalfJung @oli-obk @eddyb).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jun 7, 2022
Tested on commit rust-lang/rust@9f7e997.
Direct link to PR: <rust-lang/rust#97801>

🎉 miri on windows: build-fail → test-pass (cc @RalfJung @oli-obk @eddyb).
🎉 miri on linux: build-fail → test-pass (cc @RalfJung @oli-obk @eddyb).
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (9f7e997): comparison url.

Instruction count

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
-0.2% -0.3% 6
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) -0.2% -0.3% 6

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
-2.5% -2.5% 1
All 😿🎉 (primary) N/A N/A 0

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2

  2. number of relevant changes 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#97191
6 participants