Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify DWARF alignment in bits, not bytes. #97846

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

pcwalton
Copy link
Contributor

@pcwalton pcwalton commented Jun 7, 2022

In DWARF, alignment of types is specified in bits, as is made clear by the
parameter name AlignInBits. However, rustc was incorrectly passing a byte
alignment. This commit fixes that.

This was noticed in upstream LLVM when I tried to check in a test consisting of
LLVM IR generated from rustc and it triggered assertions 1.

In DWARF, alignment of types is specified in bits, as is made clear by the
parameter name `AlignInBits`. However, `rustc` was incorrectly passing a byte
alignment. This commit fixes that.

This was noticed in upstream LLVM when I tried to check in a test consisting of
LLVM IR generated from `rustc` and it triggered assertions [1].

[1]: https://reviews.llvm.org/D126835
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 7, 2022
@rust-highfive
Copy link
Collaborator

r? @cjgillot

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 7, 2022
@pcwalton
Copy link
Contributor Author

pcwalton commented Jun 7, 2022

r? @michaelwoerister

@pcwalton
Copy link
Contributor Author

pcwalton commented Jun 8, 2022

Anyone is free to review this as it's a pretty clear fix.

@michaelwoerister
Copy link
Member

Thanks, @pcwalton!
@bors r+

@bors
Copy link
Contributor

bors commented Jun 8, 2022

📌 Commit fe533e8 has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 8, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 8, 2022
…ster

Specify DWARF alignment in bits, not bytes.

In DWARF, alignment of types is specified in bits, as is made clear by the
parameter name `AlignInBits`. However, `rustc` was incorrectly passing a byte
alignment. This commit fixes that.

This was noticed in upstream LLVM when I tried to check in a test consisting of
LLVM IR generated from `rustc` and it triggered assertions [1].

[1]: https://reviews.llvm.org/D126835
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 8, 2022
Rollup of 5 pull requests

Successful merges:

 - rust-lang#97276 (Stabilize `const_intrinsic_copy`)
 - rust-lang#97763 (Allow ptr_from_addr_cast to fail)
 - rust-lang#97846 (Specify DWARF alignment in bits, not bytes.)
 - rust-lang#97848 (Impl Traits lowering minor refactors)
 - rust-lang#97865 (remove `BorrowckMode`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 82a1d79 into rust-lang:master Jun 8, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 8, 2022
@pcwalton pcwalton deleted the align-bits branch June 8, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants