Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __CxxFrameHandler3 to panic_abort for UEFI #98141

Closed
wants to merge 1 commit into from

Conversation

Ayush1325
Copy link
Contributor

This function is needed to compile std under UEFI.

Related to #98133

Maybe it should be present for the whole llvm-windows target family?

This function is needed to compile std under UEFI.
@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 15, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @m-ou-se (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 15, 2022
@eggyal
Copy link
Contributor

eggyal commented Jun 15, 2022

Apologies for leading you down this path. Following my comment on the issue, we've had some discussion on the t-libs Zulip stream and I'm no longer convinced this is a correct solution. The problem only arises when compiling with -Cpanic=abort for msvc target with no_std (or restricted_std) and, per discussion in #86801, we need to tread carefully here...

@Ayush1325
Copy link
Contributor Author

Apologies for leading you down this path. Following my comment on the issue, we've had some discussion on the t-libs Zulip stream and I'm no longer convinced this is a correct solution. The problem only arises when compiling with -Cpanic=abort for msvc target with no_std (or restricted_std) and, per discussion in #86801, we need to tread carefully here...

No problem. So I should close this PR now, right?

@Ayush1325
Copy link
Contributor Author

I am closing this PR now since the latest master fixes #98133

@Ayush1325 Ayush1325 closed this Jun 16, 2022
@Ayush1325 Ayush1325 deleted the uefi-std-panic-abort branch June 28, 2022 17:51
@workingjubilee workingjubilee added the O-UEFI UEFI label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-UEFI UEFI S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants