Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement for<> lifetime binder for closures #98705

Merged
merged 12 commits into from
Jul 14, 2022
Merged

Implement for<> lifetime binder for closures #98705

merged 12 commits into from
Jul 14, 2022

Commits on Jul 12, 2022

  1. Parse closure binders 

    This is first step in implementing RFC 3216.
- Parse `for<'a>` before closures in ast
  - Error in lowering
- Add `closure_lifetime_binder` feature
    @WaffleLapkin
    WaffleLapkin committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    40ae7b5 View commit details
    Browse the repository at this point in the history

  2. --bless tests

    @WaffleLapkin
    WaffleLapkin committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    97fcead View commit details
    Browse the repository at this point in the history

  3. Comment out expr size check

    @WaffleLapkin
    WaffleLapkin committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    f89ef3c View commit details
    Browse the repository at this point in the history

  4. Lower closure binders to hir & properly check them

    @WaffleLapkin
    WaffleLapkin committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    c2dbd62 View commit details
    Browse the repository at this point in the history

  5. make for<> in closures a possible place to suggest adding named lifetime

    @WaffleLapkin
    WaffleLapkin committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    0c28484 View commit details
    Browse the repository at this point in the history

  6. add test for implicit stuff in signatures of closures with for<>

    @WaffleLapkin
    WaffleLapkin committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    577f3c6 View commit details
    Browse the repository at this point in the history

  7. Add LifetimeBinderKind::Closure

    @WaffleLapkin
    WaffleLapkin committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    3ebb852 View commit details
    Browse the repository at this point in the history

  8. Add an indirection for closures in hir::ExprKind 

    This helps bring `hir::Expr` size down, `Closure` was the biggest
variant, especially after `for<>` additions.
    @WaffleLapkin
    WaffleLapkin committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    df4fee9 View commit details
    Browse the repository at this point in the history

  9. Add back expr size checks

    @WaffleLapkin
    WaffleLapkin committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    d2923b4 View commit details
    Browse the repository at this point in the history

  10. implement rustfmt formatting for for<> closure binders

    @WaffleLapkin
    WaffleLapkin committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    b504a18 View commit details
    Browse the repository at this point in the history

  11. Add rustfmt test for formatting for<> before closures

    @WaffleLapkin
    WaffleLapkin committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    30a3673 View commit details
    Browse the repository at this point in the history

  12. Fix clippy build

    @WaffleLapkin
    WaffleLapkin committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    9aa142b View commit details
    Browse the repository at this point in the history