Clarify MIR semantics of checked binary operations #98738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-compiler
|
This PR changes MIR |
|
r? @cjgillot (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
oli-obk
reviewed
Jul 1, 2022
|
I'll defer review to MIR semantics specialists. |
|
@bors r+ rollup |
|
📌 Commit b884797 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Jul 4, 2022
Clarify MIR semantics of checked binary operations
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 4, 2022
Clarify MIR semantics of checked binary operations
RalfJung
reviewed
Jul 4, 2022
| /// | ||
| /// For shift operations on integers the error condition is set when the value of right-hand | ||
| /// side is greater than or equal to the number of bits in the type of the left-hand side, or | ||
| /// when the value of right-hand side is negative. |
There was a problem hiding this comment.
Note that the "negative" thing is rather subtle currently: codegen doesn't actually check whether the type is signed or not. If we had u256, then the current codegen logic would break. See here for details.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 4, 2022
Clarify MIR semantics of checked binary operations
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 4, 2022
…askrgr Rollup of 8 pull requests Successful merges: - rust-lang#98738 (Clarify MIR semantics of checked binary operations) - rust-lang#98782 (Improve spans for specialization error) - rust-lang#98793 (Lint against executable files in the root directory) - rust-lang#98814 (rustdoc: Censor certain complex unevaluated const exprs) - rust-lang#98878 (add more `rustc_pass_by_value`) - rust-lang#98879 (Fix "wrap closure in parenthesis" suggestion for `async` closure) - rust-lang#98886 (incr.comp.: Make split-dwarf commandline options [TRACKED].) - rust-lang#98898 (Add "no-div-regex" eslint rule) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 5, 2022
…li-obk interpret: fix CheckedBinOp behavior when overflow checking is disabled Adjusts the interpreter to rust-lang#98738. r? `@oli-obk`
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 5, 2022
…li-obk interpret: fix CheckedBinOp behavior when overflow checking is disabled Adjusts the interpreter to rust-lang#98738. r? ``@oli-obk``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.