rustdoc-json-types: Clean up derives. #98789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes rust-lang#96189 Closes rust-lang#96189 Everything is `Clone, Debug, PartialEq, Eq, Hash, Serialize, Deserialize` except `Crate` and `Item` which arn't `Hash`, as they have `HashMap`'s. See linked issue for reasoning.
rustbot
added
the
T-rustdoc
|
r? @jsha (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 13, 2022
rustdoc-json-types: Clean up derives. Closes rust-lang#96189 Everything is `Clone, Debug, PartialEq, Eq, Hash, Serialize, Deserialize` except `Crate` and `Item` which arn't `Hash`, as they have `HashMap`'s. See linked issue for reasoning. `@rustbot` modify labels: +T-rustdoc +A-rustdoc-json
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
Jul 13, 2022
rustdoc-json-types: Clean up derives. Closes rust-lang#96189 Everything is `Clone, Debug, PartialEq, Eq, Hash, Serialize, Deserialize` except `Crate` and `Item` which arn't `Hash`, as they have `HashMap`'s. See linked issue for reasoning. ```@rustbot``` modify labels: +T-rustdoc +A-rustdoc-json
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 13, 2022
…laumeGomez Rollup of 10 pull requests Successful merges: - rust-lang#98789 (rustdoc-json-types: Clean up derives.) - rust-lang#98848 (Build the Clippy book as part of x.py doc) - rust-lang#99020 (check non_exhaustive attr and private fields for transparent types) - rust-lang#99132 (Add some autolabels for A-bootstrap and T-infra) - rust-lang#99148 (Clarify that [iu]size bounds were only defined for the target arch) - rust-lang#99152 (Use CSS variables to handle theming (part 2)) - rust-lang#99168 (Add regression test for rust-lang#74713) - rust-lang#99176 (:arrow_up: rust-analyzer) - rust-lang#99183 (Mention rust-analyzer maintainers when `proc_macro` bridge is changed) - rust-lang#99185 (llvm-wrapper: adapt for LLVM API change) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
aDotInTheVoid
added a commit
to rust-lang/rustdoc-types
that referenced
this pull request
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #96189
Everything is
Clone, Debug, PartialEq, Eq, Hash, Serialize, DeserializeexceptCrateandItemwhich arn'tHash, as they haveHashMap's. See linked issue for reasoning.@rustbot modify labels: +T-rustdoc +A-rustdoc-json