-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Compute always-storage-liveness more efficiently #99025
Conversation
This comment has been minimized.
This comment has been minimized.
3abbc72
to
f6cbe9d
Compare
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #99082) made this pull request unmergeable. Please resolve the merge conflicts. |
f6cbe9d
to
59ecccb
Compare
The Miri submodule was changed cc @rust-lang/miri Some changes occurred in src/tools/cargo cc @ehuss |
I didn't mean to pull in those changes.... |
This comment has been minimized.
This comment has been minimized.
Add liveness flag where missing
This reverts commit a313dba20f1449f227e2fe0be20b7c48fd4de13b.
59ecccb
to
bca3928
Compare
@nikomatsakis and I discussed this PR and issue yesterday. The tradeoff involved is this: improving the performance of this |
The job Click to see the possible cause of the failure (guessed by this bot)
|
To elaborate slightly: We are basically trading off doing an O(1) walk of the MIR with having to keep some kind of flag up-to-date. It's reasonably easy to set that flag correctly when building the MIR initially, but keeping it up to date as liveness statements are added/removed etc seems harder, and harder to guarantee going forward. Unless this code is a perf hit, I'd be inclined to just recompute the property. |
… r=oli-obk Remove FIXME from MIR `always_storage_live_locals` See discussion in rust-lang#99025 (comment).
… r=oli-obk Remove FIXME from MIR `always_storage_live_locals` See discussion in rust-lang#99025 (comment).
See #99021.
r? @ghost