Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize core::ffi::CStr, alloc::ffi::CString, and friends #99277

Merged
merged 1 commit into from
Jul 16, 2022
Merged

Stabilize core::ffi::CStr, alloc::ffi::CString, and friends #99277

merged 1 commit into from
Jul 16, 2022

Conversation

joshtriplett
Copy link
Member

Stabilize the core_c_str and alloc_c_string feature gates.

Change std::ffi to re-export these types rather than creating type
aliases, since they now have matching stability.

@joshtriplett
Stabilize core::ffi::CStr, alloc::ffi::CString, and friends
d6b7480 
Stabilize the `core_c_str` and `alloc_c_string` feature gates.

Change `std::ffi` to re-export these types rather than creating type
aliases, since they now have matching stability.
@rustbot
Copy link
Collaborator

rustbot commented Jul 15, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 15, 2022
@joshtriplett joshtriplett added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. labels Jul 15, 2022
@joshtriplett
Copy link
Member Author

FCP to stabilize completed in #98314 .

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 15, 2022

📌 Commit d6b7480 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2022
@JohnTitor JohnTitor mentioned this pull request Jul 16, 2022
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Jul 16, 2022
@JohnTitor
Rollup merge of rust-lang#99277 - joshtriplett:stabilize-core-cstr-al…
512922a 
…loc-cstring, r=Mark-Simulacrum

Stabilize `core::ffi::CStr`, `alloc::ffi::CString`, and friends

Stabilize the `core_c_str` and `alloc_c_string` feature gates.

Change `std::ffi` to re-export these types rather than creating type
aliases, since they now have matching stability.
@JohnTitor JohnTitor mentioned this pull request Jul 16, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 16, 2022
@bors
Auto merge of rust-lang#99315 - JohnTitor:rollup-77wzoc1, r=JohnTitor
7210e46 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#98387 (Add new unstable API `downcast` to `std::io::Error`)
 - rust-lang#98662 (Add std::fs::write documentation precision)
 - rust-lang#99253 (Remove FIXME from MIR `always_storage_live_locals`)
 - rust-lang#99264 (Fix typo in mod.rs)
 - rust-lang#99270 (Add `#[must_use]` to `Box::from_raw`)
 - rust-lang#99277 (Stabilize `core::ffi::CStr`, `alloc::ffi::CString`, and friends)
 - rust-lang#99307 (Add regression test for rust-lang#64401)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 083a253 into rust-lang:master Jul 16, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 16, 2022
@joshtriplett joshtriplett mentioned this pull request Jul 16, 2022
Closed
3 tasks
This was referenced Jul 19, 2022
Open
Closed
@upsuper upsuper mentioned this pull request Aug 6, 2022
Closed
@i509VCB i509VCB mentioned this pull request Aug 17, 2022
Open
@rzezeski rzezeski mentioned this pull request Sep 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
5 participants
@joshtriplett @rustbot @rust-highfive @Mark-Simulacrum @bors