Make {integer}::from_str_radix constant #99322

GKFX · 2022-07-16T11:56:23Z

This commit makes FromStr on integers constant so that const x: u32 = "23".parse(); works. More practical use-case is with environment variables at build time as discussed in rust-lang/rfcs#1907.

Tracking issue #59133.

ACP: rust-lang/libs-team#74

rustbot · 2022-07-16T11:56:26Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

rust-highfive · 2022-07-16T11:56:26Z

r? @thomcc

(rust-highfive has picked a reviewer for you, use r? to override)

GKFX · 2022-07-16T11:59:26Z

@rustbot label +T-libs-api -T-libs

library/core/src/cmp.rs

library/core/src/fmt/mod.rs

thomcc · 2022-07-19T06:41:30Z

Can you file an API change proposal, as requested by the bot? Thanks.

If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already

GKFX · 2022-07-19T06:51:03Z

Done: rust-lang/libs-team#74

thomcc

~~The implementation looks largely fine, so r=me pending api review.~~ The implementation has changed enough that I'd like to re-review.

library/core/src/fmt/mod.rs

bors · 2022-07-19T12:14:03Z

☔ The latest upstream changes (presumably #99451) made this pull request unmergeable. Please resolve the merge conflicts.

library/core/src/num/mod.rs

library/core/src/fmt/num.rs

library/core/src/num/mod.rs

bors · 2022-07-26T02:23:02Z

☔ The latest upstream changes (presumably #99735) made this pull request unmergeable. Please resolve the merge conflicts.

GKFX · 2022-08-13T20:27:52Z

@rustbot ready
Assuming the CI passes I think this is now in better shape. #92390 got merged so I have removed that code, and the use of const_eval_select avoided the need to figure out how to do const-compatible string formatting so those changes are also gone.

thomcc · 2022-08-22T10:45:54Z

I'm not sure if making something like this constified is doable yet, so CC @rust-lang/wg-const-eval (and see also rust-lang/libs-team#74)

Mark-Simulacrum · 2024-03-30T12:26:56Z

Needs a rebase, but r=me on current state.

GKFX · 2024-03-30T13:44:23Z

@rustbot ready

Rebased again.

Mark-Simulacrum · 2024-03-30T14:12:53Z

@bors r+

GKFX · 2024-03-30T16:05:20Z

@Mark-Simulacrum Bors doesn't seem to have responded to your comment and this PR doesn't seem to be visible at https://bors.rust-lang.org/queue/rust. Is it stuck in some way?

Mark-Simulacrum · 2024-03-30T16:14:51Z

@bors r+

bors · 2024-03-30T16:14:53Z

📌 Commit 3855b8b has been approved by Mark-Simulacrum

It is now in the queue for this repository.

bors · 2024-03-30T19:57:01Z

⌛ Testing commit 3855b8b with merge 8df7e72...

bors · 2024-03-30T21:57:43Z

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 8df7e72 to master...

rust-timer · 2024-03-30T23:55:46Z

Finished benchmarking commit (8df7e72): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	1
Improvements ✅ (primary)	-0.4%	[-0.8%, -0.0%]	12
Improvements ✅ (secondary)	-0.4%	[-1.3%, -0.0%]	72
All ❌✅ (primary)	-0.4%	[-0.8%, -0.0%]	12

Bootstrap: 667.994s -> 669.242s (0.19%)
Artifact size: 315.79 MiB -> 315.71 MiB (-0.03%)

…tr, r=dtolnay Stabilize const `{integer}::from_str_radix` i.e. `const_int_from_str` This PR stabilizes the feature `const_int_from_str`. - ACP Issue: rust-lang/libs-team#74 - Implementation PR: rust-lang#99322 - Part of Tracking Issue: rust-lang#59133 API Change Diff: ```diff impl {integer} { - pub fn from_str_radix(src: &str, radix: u32) -> Result<Self, ParseIntError>; + pub const fn from_str_radix(src: &str, radix: u32) -> Result<Self, ParseIntError>; } impl ParseIntError { - pub fn kind(&self) -> &IntErrorKind; + pub const fn kind(&self) -> &IntErrorKind; } ``` This makes it easier to parse integers at compile-time, e.g. the example from the Tracking Issue: ```rust env!("SOMETHING").parse::<usize>().unwrap() ``` could now be achived with ```rust match usize::from_str_radix(env!("SOMETHING"), 10) { Ok(val) => val, Err(err) => panic!("Invalid value for SOMETHING environment variable."), } ``` rather than having to depend on a library that implements or manually implement the parsing at compile-time. --- Checklist based on [Libs Stabilization Guide - When there's const involved](https://std-dev-guide.rust-lang.org/development/stabilization.html#when-theres-const-involved) I am treating this as a [partial stabilization](https://std-dev-guide.rust-lang.org/development/stabilization.html#partial-stabilizations) as it shares a tracking issue (and is rather small), so directly opening the partial stabilization PR for the subset (feature `const_int_from_str`) being stabilized. - [x] ping Constant Evaluation WG - [x] no unsafe involved - [x] no `#[allow_internal_unstable]` - [ ] usage of `intrinsic::const_eval_select` rust-lang#124625 in `from_str_radix_assert` to change the error message between compile-time and run-time - [ ] [rust-labg/libs-api FCP](rust-lang#124941 (comment))

Rollup merge of rust-lang#124941 - Skgland:stabilize-const-int-from-str, r=dtolnay Stabilize const `{integer}::from_str_radix` i.e. `const_int_from_str` This PR stabilizes the feature `const_int_from_str`. - ACP Issue: rust-lang/libs-team#74 - Implementation PR: rust-lang#99322 - Part of Tracking Issue: rust-lang#59133 API Change Diff: ```diff impl {integer} { - pub fn from_str_radix(src: &str, radix: u32) -> Result<Self, ParseIntError>; + pub const fn from_str_radix(src: &str, radix: u32) -> Result<Self, ParseIntError>; } impl ParseIntError { - pub fn kind(&self) -> &IntErrorKind; + pub const fn kind(&self) -> &IntErrorKind; } ``` This makes it easier to parse integers at compile-time, e.g. the example from the Tracking Issue: ```rust env!("SOMETHING").parse::<usize>().unwrap() ``` could now be achived with ```rust match usize::from_str_radix(env!("SOMETHING"), 10) { Ok(val) => val, Err(err) => panic!("Invalid value for SOMETHING environment variable."), } ``` rather than having to depend on a library that implements or manually implement the parsing at compile-time. --- Checklist based on [Libs Stabilization Guide - When there's const involved](https://std-dev-guide.rust-lang.org/development/stabilization.html#when-theres-const-involved) I am treating this as a [partial stabilization](https://std-dev-guide.rust-lang.org/development/stabilization.html#partial-stabilizations) as it shares a tracking issue (and is rather small), so directly opening the partial stabilization PR for the subset (feature `const_int_from_str`) being stabilized. - [x] ping Constant Evaluation WG - [x] no unsafe involved - [x] no `#[allow_internal_unstable]` - [ ] usage of `intrinsic::const_eval_select` rust-lang#124625 in `from_str_radix_assert` to change the error message between compile-time and run-time - [ ] [rust-labg/libs-api FCP](rust-lang#124941 (comment))

…lnay Stabilize const `{integer}::from_str_radix` i.e. `const_int_from_str` This PR stabilizes the feature `const_int_from_str`. - ACP Issue: rust-lang/libs-team#74 - Implementation PR: rust-lang/rust#99322 - Part of Tracking Issue: rust-lang/rust#59133 API Change Diff: ```diff impl {integer} { - pub fn from_str_radix(src: &str, radix: u32) -> Result<Self, ParseIntError>; + pub const fn from_str_radix(src: &str, radix: u32) -> Result<Self, ParseIntError>; } impl ParseIntError { - pub fn kind(&self) -> &IntErrorKind; + pub const fn kind(&self) -> &IntErrorKind; } ``` This makes it easier to parse integers at compile-time, e.g. the example from the Tracking Issue: ```rust env!("SOMETHING").parse::<usize>().unwrap() ``` could now be achived with ```rust match usize::from_str_radix(env!("SOMETHING"), 10) { Ok(val) => val, Err(err) => panic!("Invalid value for SOMETHING environment variable."), } ``` rather than having to depend on a library that implements or manually implement the parsing at compile-time. --- Checklist based on [Libs Stabilization Guide - When there's const involved](https://std-dev-guide.rust-lang.org/development/stabilization.html#when-theres-const-involved) I am treating this as a [partial stabilization](https://std-dev-guide.rust-lang.org/development/stabilization.html#partial-stabilizations) as it shares a tracking issue (and is rather small), so directly opening the partial stabilization PR for the subset (feature `const_int_from_str`) being stabilized. - [x] ping Constant Evaluation WG - [x] no unsafe involved - [x] no `#[allow_internal_unstable]` - [ ] usage of `intrinsic::const_eval_select` rust-lang/rust#124625 in `from_str_radix_assert` to change the error message between compile-time and run-time - [ ] [rust-labg/libs-api FCP](rust-lang/rust#124941 (comment))

rust-highfive assigned thomcc Jul 16, 2022

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jul 16, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 16, 2022

rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 16, 2022

GKFX commented Jul 16, 2022

View reviewed changes

library/core/src/cmp.rs Outdated Show resolved Hide resolved

GKFX commented Jul 16, 2022

View reviewed changes

library/core/src/fmt/mod.rs Outdated Show resolved Hide resolved

GKFX mentioned this pull request Jul 19, 2022

Make FromStr on integers const rust-lang/libs-team#74

Closed

thomcc reviewed Jul 19, 2022

View reviewed changes

library/core/src/fmt/mod.rs Outdated Show resolved Hide resolved

klensy reviewed Jul 19, 2022

View reviewed changes

library/core/src/num/mod.rs Outdated Show resolved Hide resolved

thomcc added S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2022

GKFX commented Jul 22, 2022

View reviewed changes

library/core/src/fmt/num.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

GKFX force-pushed the const-int-parse branch from 5f73b02 to 2a40e6a Compare July 23, 2022 16:02

fee1-dead reviewed Jul 24, 2022

View reviewed changes

library/core/src/num/mod.rs Outdated Show resolved Hide resolved

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 26, 2022

GKFX force-pushed the const-int-parse branch 2 times, most recently from 0c27bcd to e0da0a3 Compare August 13, 2022 19:50

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 13, 2022

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 24, 2024

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. const-hack labels Mar 30, 2024

Make {integer}::from_str_radix constant

3855b8b

GKFX force-pushed the const-int-parse branch from e370955 to 3855b8b Compare March 30, 2024 12:47

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 30, 2024

Mark-Simulacrum closed this Mar 30, 2024

Mark-Simulacrum reopened this Mar 30, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 30, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 30, 2024

bors merged commit 8df7e72 into rust-lang:master Mar 30, 2024
23 checks passed

rustbot added this to the 1.79.0 milestone Mar 30, 2024

Skgland mentioned this pull request May 9, 2024

Stabilize const {integer}::from_str_radix i.e. const_int_from_str #124941

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make {integer}::from_str_radix constant #99322

Make {integer}::from_str_radix constant #99322

GKFX commented Jul 16, 2022 •

edited by Mark-Simulacrum

Loading

rustbot commented Jul 16, 2022

rust-highfive commented Jul 16, 2022

GKFX commented Jul 16, 2022

thomcc commented Jul 19, 2022

GKFX commented Jul 19, 2022

thomcc left a comment •

edited

Loading

bors commented Jul 19, 2022

This comment has been minimized.

bors commented Jul 26, 2022

GKFX commented Aug 13, 2022

thomcc commented Aug 22, 2022

Mark-Simulacrum commented Mar 30, 2024

GKFX commented Mar 30, 2024

Mark-Simulacrum commented Mar 30, 2024

GKFX commented Mar 30, 2024

Mark-Simulacrum commented Mar 30, 2024

bors commented Mar 30, 2024

bors commented Mar 30, 2024

bors commented Mar 30, 2024

rust-timer commented Mar 30, 2024

Make {integer}::from_str_radix constant #99322

Make {integer}::from_str_radix constant #99322

Conversation

GKFX commented Jul 16, 2022 • edited by Mark-Simulacrum Loading

rustbot commented Jul 16, 2022

rust-highfive commented Jul 16, 2022

GKFX commented Jul 16, 2022

thomcc commented Jul 19, 2022

GKFX commented Jul 19, 2022

thomcc left a comment • edited Loading

Choose a reason for hiding this comment

bors commented Jul 19, 2022

This comment has been minimized.

bors commented Jul 26, 2022

GKFX commented Aug 13, 2022

thomcc commented Aug 22, 2022

Mark-Simulacrum commented Mar 30, 2024

GKFX commented Mar 30, 2024

Mark-Simulacrum commented Mar 30, 2024

GKFX commented Mar 30, 2024

Mark-Simulacrum commented Mar 30, 2024

bors commented Mar 30, 2024

bors commented Mar 30, 2024

bors commented Mar 30, 2024

rust-timer commented Mar 30, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

GKFX commented Jul 16, 2022 •

edited by Mark-Simulacrum

Loading

thomcc left a comment •

edited

Loading