-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uplift clippy::for_loops_over_fallibles
lint into rustc
#99696
Merged
Merged
+381
−366
Commits on Oct 9, 2022
-
Start uplifting
clippy::for_loops_over_fallibles
I refactored the code: - Removed handling of methods, as it felt entirely unnecessary - Removed clippy utils (obviously...) - Used some shiny compiler features (let-else is very handy for lints 👀) - I also renamed the lint to `for_loop_over_fallibles` (note: no `s`). I'm not sure what's the naming convention here, so maybe I'm wrong.
Configuration menu - View commit details
-
Copy full SHA for fa380a8 - Browse repository at this point
Copy the full SHA fa380a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d030ba5 - Browse repository at this point
Copy the full SHA d030ba5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21ec99b - Browse repository at this point
Copy the full SHA 21ec99bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5dcfdbf - Browse repository at this point
Copy the full SHA 5dcfdbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for b2975ee - Browse repository at this point
Copy the full SHA b2975eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd842ff - Browse repository at this point
Copy the full SHA dd842ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7308564 - Browse repository at this point
Copy the full SHA 7308564View commit details -
for_loop_over_fallibles
: fix suggestion for "remove.next()
" caseif the iterator is used after the loop, we need to use `.by_ref()`
Configuration menu - View commit details
-
Copy full SHA for 23a7674 - Browse repository at this point
Copy the full SHA 23a7674View commit details -
for_loop_over_fallibles
: don't useMachineApplicable
The loop could contain `break;` that won't work with an `if let`
Configuration menu - View commit details
-
Copy full SHA for 8ca57b5 - Browse repository at this point
Copy the full SHA 8ca57b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0250f02 - Browse repository at this point
Copy the full SHA 0250f02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75ae20a - Browse repository at this point
Copy the full SHA 75ae20aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b9b2059 - Browse repository at this point
Copy the full SHA b9b2059View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6766113 - Browse repository at this point
Copy the full SHA 6766113View commit details -
Configuration menu - View commit details
-
Copy full SHA for 98e0c4d - Browse repository at this point
Copy the full SHA 98e0c4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c64bb1 - Browse repository at this point
Copy the full SHA 9c64bb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7434b9f - Browse repository at this point
Copy the full SHA 7434b9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 40f36fa - Browse repository at this point
Copy the full SHA 40f36faView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5347c81 - Browse repository at this point
Copy the full SHA 5347c81View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d4edff - Browse repository at this point
Copy the full SHA 9d4edffView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.