Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some FulfillmentContext-related cleanups #99743

Merged
merged 6 commits into from
Aug 6, 2022
Merged

Some FulfillmentContext-related cleanups #99743

merged 6 commits into from
Aug 6, 2022

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Jul 26, 2022 •
edited
Loading

Use ObligationCtxt in some places, remove some FulfillmentContexts in others...

r? types

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 26, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 26, 2022
@compiler-errors compiler-errors force-pushed the fulfillment-context-cleanups branch from f8fcd55 to 0da2bb0 Compare August 2, 2022 06:30
@rustbot
Copy link
Collaborator

rustbot commented Aug 2, 2022

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@compiler-errors compiler-errors force-pushed the fulfillment-context-cleanups branch from 0da2bb0 to 89e10d8 Compare August 2, 2022 06:44
jackh726
jackh726 approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple comments, but r=me otherwise

compiler/rustc_trait_selection/src/traits/mod.rs Outdated Show resolved Hide resolved
compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs Outdated Show resolved Hide resolved
@bors
Copy link
Contributor

bors commented Aug 4, 2022

☔ The latest upstream changes (presumably #100120) made this pull request unmergeable. Please resolve the merge conflicts.

@compiler-errors compiler-errors force-pushed the fulfillment-context-cleanups branch from 89e10d8 to f5af266 Compare August 4, 2022 13:59
@compiler-errors
Copy link
Member Author

@bors r=jackh726

@bors
Copy link
Contributor

bors commented Aug 5, 2022

📌 Commit f5af266 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2022
@bors
Copy link
Contributor

bors commented Aug 6, 2022

⌛ Testing commit f5af266 with merge bd04658...

@bors
Copy link
Contributor

bors commented Aug 6, 2022

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing bd04658 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 6, 2022
@bors bors merged commit bd04658 into rust-lang:master Aug 6, 2022
@rustbot rustbot added this to the 1.64.0 milestone Aug 6, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bd04658): comparison url.

Instruction count

  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 1.3% 1.5% 6
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) N/A N/A 0

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 2.6% 2.6% 1
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -3.7% -5.2% 2
All 😿🎉 (primary) N/A N/A 0

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

flip1995 pushed a commit to flip1995/rust that referenced this pull request Aug 11, 2022
@bors
Auto merge of rust-lang#99743 - compiler-errors:fulfillment-context-c…
f719599 
…leanups, r=jackh726

Some `FulfillmentContext`-related cleanups

Use `ObligationCtxt` in some places, remove some `FulfillmentContext`s in others...

r? types
@ehuss ehuss modified the milestones: 1.64.0, 1.65.0 Aug 31, 2022
@compiler-errors compiler-errors deleted the fulfillment-context-cleanups branch August 11, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackh726 jackh726 jackh726 approved these changes

Assignees

@jackh726 jackh726

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
8 participants
@compiler-errors @rustbot @rust-log-analyzer @bors @rust-timer @jackh726 @ehuss @rust-highfive