-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuchsia CI zircon lib improvement #99833
Fuchsia CI zircon lib improvement #99833
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
src/ci/docker/host-x86_64/dist-various-2/build-fuchsia-toolchain.sh
Outdated
Show resolved
Hide resolved
src/ci/docker/host-x86_64/dist-various-2/build-fuchsia-toolchain.sh
Outdated
Show resolved
Hide resolved
src/ci/docker/host-x86_64/dist-various-2/build-fuchsia-toolchain.sh
Outdated
Show resolved
Hide resolved
Also, can you squash your fixup commits? |
ac4e3e0
to
9eeb2fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me after the last change I requested. @pietroalbini want to give this a once over?
9eeb2fe
to
6e03ed6
Compare
I may have heard that Pietro was on vacation, r? @rust-lang/infra |
r? rust-lang/infra-ci (you can see the list of teams highfive accepts at https://github.com/rust-lang/highfive/blob/master/highfive/configs/rust-lang/rust.json) |
src/ci/docker/host-x86_64/dist-various-2/build-fuchsia-toolchain.sh
Outdated
Show resolved
Hide resolved
src/ci/docker/host-x86_64/dist-various-2/build-fuchsia-toolchain.sh
Outdated
Show resolved
Hide resolved
6e03ed6
to
976da4e
Compare
Unable to mark a re-request review; thank you for the feedback @petrhosek ! Please let me know if any other additions would be good to add |
242c03f
to
d98b6d2
Compare
@bors r+ rollup=iffy |
📌 Commit d98b6d2d9935eb0fbf78045263c6991b8a5f759e has been approved by It is now in the queue for this repository. |
⌛ Testing commit d98b6d2d9935eb0fbf78045263c6991b8a5f759e with merge 95ffcfe4ed162665fb8191b6fa69e98f47a47492... |
@bors r+ |
📌 Commit c913a06937f2952a7c80b142d363e01146a4c2f7 has been approved by It is now in the queue for this repository. |
⌛ Testing commit c913a06937f2952a7c80b142d363e01146a4c2f7 with merge fcb586e9fb67607b468f89e441a036d48938997c... |
💔 Test failed - checks-actions |
This comment has been minimized.
This comment has been minimized.
PR feedback PR Followups Updating clang download Updating clang download Restructuring env used Restructuring env used Adding chmod Adding chmod Adding chmod
c913a06
to
fa4ce7a
Compare
@bors r+ |
☀️ Test successful - checks-actions |
Thank you @Mark-Simulacrum for helping on this! I really appreciate it 🙏 |
Finished benchmarking commit (9ee22ff): comparison url. Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
…, r=tmandry Use llvm-libunwind="in-tree" for Fuchsia targets With updates to Fuchsia CI's Zircon libraries rust-lang#99833, we can introduce `llvm-libunwind="in-tree"` for Fuchsia targets. This PR restores functionality removed from rust-lang#93604 (comment). cc `@tmandry` `@djkoloski`
Removing Zircon build process, instead pulling
sysroot
and related libs directly from Fuchsia SDKcc. @tmandry @djkoloski