-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: revert #99212 #99905
perf: revert #99212 #99905
Conversation
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
r? @ghost |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 4078ee4 with merge cd02069df6812a8a1be9589e05a040bb6fc16b4e... |
☀️ Try build successful - checks-actions |
Queued cd02069df6812a8a1be9589e05a040bb6fc16b4e with parent 2f847b8, future comparison URL. |
Finished benchmarking commit (cd02069df6812a8a1be9589e05a040bb6fc16b4e): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Footnotes |
It should be possible to negate the perf impact of #99212, I'll look into it and close this for now. |
…ercote passes: load `defined_lib_features` query less Hopefully addresses the perf regressions from rust-lang#99212 (see rust-lang#99905). Re-structure the stability checks for library features to avoid calling `defined_lib_features` for any more crates than necessary for each of the implications or local feature attributes that need validation. r? `@ghost` (just checking perf at first)
Reverts #99212 to check the performance impact of that pull request. I don't expect that we'll need to land this - if a perf impact is revealed then I'll submit a new PR that fixes it.