date-check: updating-llvm #1424

tshepang · 2022-08-10T20:47:31Z

JohnTitor · 2022-08-11T01:59:04Z

src/backend/updating-llvm.md

-* A new feature may be available in LLVM that we want to use in rustc,
-  but we don't want to wait for a full LLVM release to test it out.
-
-* LLVM itself may have a new release and we'd like to update to this LLVM
-  release.
+* LLVM itself may have a new release.


We shouldn't merge them as these two things are different, a new feature that isn't released may be cherry-picked into Rust's LLVM fork, e.g. rust-lang/llvm-project#135.

interesting, because @nikic said it is not done any more, maybe because it is rare in the recent past

@nikic Is that true? I thought the above PR is an example of a new feature cherry-picked into our LLVM fork.

The relevant distinction here is between a cherry-pick (bug fix or self-contained feature) and a rebase (new release). The thing we don't do any more is to rebase without a new (pending) release.

Thanks for clarifying! I think that should be documented above, the current sounds somewhat confusing.

src/backend/updating-llvm.md

rust-lang#1424 (comment)

Merge Feature updates and LLVM release section, because the former no longer happens. -- source https://rust-lang.zulipchat.com/#narrow/stream/187780-t-compiler.2Fwg-llvm/topic/is.20Updating.20LLVM.20on.20rustc-dev-guide.20current

rust-lang#1424 (comment)

tshepang · 2022-09-20T19:36:31Z

@JohnTitor see latest commit, where I include info about the rebase

JohnTitor · 2022-11-20T03:55:04Z

Sorry for the loooong delay, I somehow missed your ping...(feel free to ping again if I don't respond for a week or more!) I've now understood the context and it LGTM, thanks for updating it <3

Update books ## rust-lang/book 1 commits in 3f64052c048c6def93b94a2b514ee88bba918744..a60f4316ec923a5ac2ed6a2eba6960edb832d855 2022-11-16 15:07:18 UTC to 2022-11-16 15:07:18 UTC - Fix Install MdBook command (rust-lang/book#3424) ## rust-embedded/book 4 commits in c533348edd69f11a8f4225d633a05d7093fddbf3..19f798d448835a4888e3b3eae7fe69f1d61d8681 2022-11-17 15:08:11 UTC to 2022-11-08 23:27:57 UTC - start/hardware.md: Fix typo (rust-embedded/book#336) - doc: Fix `arm-none-eabi-gdb` installation instruction for Fedora 27 or newer to just use `gdb` (rust-embedded/book#335) - Update singletons.md (rust-embedded/book#334) - Remove incorrect claim HashMap is avail in no_std (rust-embedded/book#333) ## rust-lang/nomicon 2 commits in 05532356e7a4dbea2330aabb77611f5179493bb8..ae406aa5287a9e025abb72343aaceec98458c117 2022-11-21 22:48:20 UTC to 2022-11-15 00:29:20 UTC - Improve chapter about `Vec<T>` (rust-lang/nomicon#381) - Grammar change for 3.4: Limits of Lifetimes (lifetime-mismatch.md) (rust-lang/nomicon#386) ## rust-lang/reference 9 commits in 9f0cc13ffcd27c1fbe1ab766a9491e15ddcf4d19..3ae62681ff236d5528ef7c8c28ba7c6b2ecc6731 2022-12-05 00:51:50 UTC to 2022-11-15 20:43:30 UTC - Document that type parameter `Self` is unsized by default (rust-lang/reference#1285) - replace `crateid` term with `crate_name` (rust-lang/reference#1310) - Document native library modifier `verbatim` (rust-lang/reference#1299) - Update literal suffix docs for rust-lang#102944 (rust-lang/reference#1305) - update aliasing rules section of the reference (rust-lang/reference#1290) - Document RFC 2867: instruction_set attribute (rust-lang/reference#1253) - Fix a minor typo in the "Higher-ranked trait bounds" section (rust-lang/reference#1288) - Disallow newline directly following `//` (rust-lang/reference#1294) - Add an anchor to the "forwarding macro fragments" paragraph (rust-lang/reference#1300) ## rust-lang/rust-by-example 5 commits in 2b15c0abf2bada6e00553814336bc3e2d8399097..a9869b4a3c4cac3bc6099b41f088679e268400b8 2022-11-27 19:03:05 UTC to 2022-11-11 18:54:53 UTC - Migrate from highfive to triagebot (rust-lang/rust-by-example#1647) - Simpler version of the read_lines script. (rust-lang/rust-by-example#1641) - Fix comment in "Formatted print" example code (rust-lang/rust-by-example#1638) - Added a missing backtick in a comment in chapter 15.4. (rust-lang/rust-by-example#1642) - Clarify the confusing closure example rust-lang#1611 (rust-lang/rust-by-example#1643) ## rust-lang/rustc-dev-guide 13 commits in d0dc6c9..e269950 2022-12-03 23:09:24 UTC to 2022-11-08 21:35:38 UTC - Remove duplicate paragraph (rust-lang/rustc-dev-guide#1523) - clarify subtree tool policy (rust-lang/rustc-dev-guide#1518) - Typo (rust-lang/rustc-dev-guide#1520) - Link directly to the section on `--keep-stage` (rust-lang/rustc-dev-guide#1515) - do an actual link to detect if it breaks in future (rust-lang/rustc-dev-guide#1517) - Triage some date-check items (rust-lang/rustc-dev-guide#1513) - Update path for `try_mark_green` implementation (rust-lang/rustc-dev-guide#1512) - Fix a broken design docs link about unused substs bug (rust-lang/rustc-dev-guide#1511) - updating-llvm: keep a calm tone (rust-lang/rustc-dev-guide#1449) - date-check: updating-llvm (rust-lang/rustc-dev-guide#1424) - rewrite the section about regions in the trait solver (rust-lang/rustc-dev-guide#1508) - Consistent ordered list indexing (rust-lang/rustc-dev-guide#1509) - Document multiple alternative suggestions on diagnostic structs (rust-lang/rustc-dev-guide#1486)

JohnTitor reviewed Aug 11, 2022

View reviewed changes

src/backend/updating-llvm.md Outdated Show resolved Hide resolved

tshepang added a commit to tshepang/rustc-dev-guide that referenced this pull request Aug 11, 2022

address review comment

6b4c855

rust-lang#1424 (comment)

tshepang force-pushed the updating-llvm branch from f66d62d to 6b4c855 Compare August 11, 2022 05:07

JohnTitor added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Aug 13, 2022

JohnTitor mentioned this pull request Aug 13, 2022

Date Reference Triage for 2022-08 #1414

Closed

28 tasks

JohnTitor added S-waiting-on-author Status: this PR is waiting for additional action by the OP and removed S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content labels Sep 2, 2022

tshepang added 3 commits September 20, 2022 21:29

date-check: updating-llvm

c547739

Merge Feature updates and LLVM release section, because the former no longer happens. -- source https://rust-lang.zulipchat.com/#narrow/stream/187780-t-compiler.2Fwg-llvm/topic/is.20Updating.20LLVM.20on.20rustc-dev-guide.20current

address review comment

4c91030

rust-lang#1424 (comment)

address review comment

bb630e8

rust-lang#1424 (comment)

tshepang force-pushed the updating-llvm branch from 6b4c855 to bb630e8 Compare September 20, 2022 19:35

JohnTitor approved these changes Nov 20, 2022

View reviewed changes

JohnTitor merged commit 6f3d5e4 into rust-lang:master Nov 20, 2022

tshepang deleted the updating-llvm branch November 20, 2022 06:02

rustbot mentioned this pull request Dec 5, 2022

Update books rust-lang/rust#105313

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

date-check: updating-llvm #1424

date-check: updating-llvm #1424

tshepang commented Aug 10, 2022 •

edited

Loading

JohnTitor Aug 11, 2022 •

edited

Loading

tshepang Aug 11, 2022

JohnTitor Aug 11, 2022

nikic Aug 31, 2022

JohnTitor Aug 31, 2022

tshepang commented Sep 20, 2022

JohnTitor commented Nov 20, 2022

date-check: updating-llvm #1424

date-check: updating-llvm #1424

Conversation

tshepang commented Aug 10, 2022 • edited Loading

JohnTitor Aug 11, 2022 • edited Loading

Choose a reason for hiding this comment

tshepang Aug 11, 2022

Choose a reason for hiding this comment

JohnTitor Aug 11, 2022

Choose a reason for hiding this comment

nikic Aug 31, 2022

Choose a reason for hiding this comment

JohnTitor Aug 31, 2022

Choose a reason for hiding this comment

tshepang commented Sep 20, 2022

JohnTitor commented Nov 20, 2022

tshepang commented Aug 10, 2022 •

edited

Loading

JohnTitor Aug 11, 2022 •

edited

Loading