Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update actions/github-script to v6 #1521

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

JohnTitor
Copy link
Member

v5 requires to migrate from github.issues to github.rest.issues, and v6 updates Node.js image to v16.
Ref. https://github.com/actions/github-script#breaking-changes

This also removes github_token input as GITHUB_TOKEN will be used by default: https://github.com/actions/github-script#using-a-separate-github-token

Signed-off-by: Yuki Okushi jtitor@2k36.org

Signed-off-by: Yuki Okushi <jtitor@2k36.org>
@camelid
Copy link
Member

camelid commented Dec 7, 2022

Do we know if there were breaking changes in V4? In their Breaking Changes section, it only seems to talk about V5 and V6.

@JohnTitor
Copy link
Member Author

According to https://github.com/actions/github-script/releases/tag/v4.0.0 and actions/github-script@v3.1.1...v4.0.0, they seem to have added a change around require import, but I think it doesn't affect us as we only import fs.

Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for checking!

@camelid camelid merged commit 3b98da0 into rust-lang:master Dec 9, 2022
@JohnTitor JohnTitor deleted the upd-github-script branch December 9, 2022 03:17
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 19, 2022
Update books

## rust-lang/nomicon

1 commits in ae406aa5287a9e025abb72343aaceec98458c117..dd37e21ccee43918ed18a71581bb2af537ffe4fc
2022-12-09 22:04:38 UTC to 2022-12-09 22:04:38 UTC

- Update lifetime-mismatch.md (rust-lang/nomicon#387)

## rust-lang/rust-by-example

3 commits in a9869b4a3c4cac3bc6099b41f088679e268400b8..995df09b65c582eb6290ab7ea5d9485983eb4c37
2022-12-08 23:29:31 UTC to 2022-12-08 23:28:31 UTC

- Add documentation for let-else. (rust-lang/rust-by-example#1640)
- Added missing space in comment (rust-lang/rust-by-example#1644)
- Clean up Chapter 1 (Hello World) (rust-lang/rust-by-example#1650)

## rust-lang/rustc-dev-guide

8 commits in e269950a57fa6fcda356426545fb5aa3691a7ced..8b42eb5f57d3d8ed2257a22d0e850d9db52afed3
2022-12-17 22:41:27 UTC to 2022-12-07 05:42:57 UTC

- Add -Ztrack-diagnostics information (rust-lang/rustc-dev-guide#1506)
- Add documentation for LLVM KCFI support (rust-lang/rustc-dev-guide#1529)
- Replace references to NoLandingPads in MIR pass documents (rust-lang/rustc-dev-guide#1531)
- share same link (rust-lang/rustc-dev-guide#1530)
- chore: Update `actions/github-script` to v6 (rust-lang/rustc-dev-guide#1521)
- fix: Fix broken links (rust-lang/rustc-dev-guide#1522)
- Remove TyS (rust-lang/rustc-dev-guide#1526)
- Fix small inaccuracy in monomorph page (rust-lang/rustc-dev-guide#1525)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants