document difference between solvers + new solver normalization #1945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
reviewed
Mar 22, 2024
src/solve/normalization.md
Outdated
Comment on lines
14
to
15
| and returning its underlying value. If the alias is rigid, `NormalizesTo` fails and | ||
| returns `NoSolution`. |
There was a problem hiding this comment.
when does it happen that the alias is rigid?
There was a problem hiding this comment.
extended that section to explain taht
Co-authored-by: Oli Scherer <github35764891676564198441@oli-obk.de>
Co-authored-by: Oli Scherer <github35764891676564198441@oli-obk.de>
BoxyUwU
approved these changes
Mar 22, 2024
Merged
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Mar 25, 2024
Update books ## rust-lang/edition-guide 1 commits in e1eead1181a691e56299294d5f1d62fe7a26d317..98b33e9a441457b0a491fe1be90e7de64eafc3e5 2024-03-23 14:17:26 UTC to 2024-03-23 14:17:26 UTC - remove indication that C string literals don't exist yet (rust-lang/edition-guide#295) ## rust-lang/reference 4 commits in 5afb503a4c1ea3c84370f8f4c08a1cddd1cdf6ad..984b36eca4b9293df04d5ba4eb5c4f77db0f51dc 2024-03-25 14:05:19 UTC to 2024-03-19 20:01:14 UTC - Fix typo of shebang (rust-lang/reference#1486) - Document importing `main` (rust-lang/reference#1461) - add grammar for `associated_type_bounds` in reference (rust-lang/reference#1481) - Literal expressions: fix mistake in the definition of unicode escapes (rust-lang/reference#1483) ## rust-lang/rust-by-example 1 commits in e093099709456e6fd74fecd2505fdf49a2471c10..7601e0c5ad29d5bd3b518700ea63fddfff5915a7 2024-03-17 21:37:25 UTC to 2024-03-17 21:37:25 UTC - Update enum_use.md to use a more neutral theme (rust-lang/rust-by-example#1828) ## rust-lang/rustc-dev-guide 12 commits in 8a5d647f19b08998612146b1cb2ca47083db63e0..ffa246b7fd95a96e1cd54883e613aed42c32547d 2024-03-23 07:44:42 UTC to 2024-03-11 18:17:28 UTC - [MCP 723] Rename AstConv to HIR ty lowering (rust-lang/rustc-dev-guide#1916) - add chapter to summary (rust-lang/rustc-dev-guide#1947) - document difference between solvers + new solver normalization (rust-lang/rustc-dev-guide#1945) - Fix broken link in chapter '1. How to build and run the compiler' (rust-lang/rustc-dev-guide#1946) - typo (rust-lang/rustc-dev-guide#1944) - Reflect rustc_codegen_cranelift move (rust-lang/rustc-dev-guide#1941) - Update rustdoc-internals.md (rust-lang/rustc-dev-guide#1911) - Update test-implementation.md (rust-lang/rustc-dev-guide#1937) - Extract Bootstrap into its own section (rust-lang/rustc-dev-guide#1939) - typos (rust-lang/rustc-dev-guide#1938) - More updates for recent diagnostics changes. (rust-lang/rustc-dev-guide#1936) - Update bibliography.md (rust-lang/rustc-dev-guide#1912)
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Mar 25, 2024
Update books ## rust-lang/edition-guide 1 commits in e1eead1181a691e56299294d5f1d62fe7a26d317..98b33e9a441457b0a491fe1be90e7de64eafc3e5 2024-03-23 14:17:26 UTC to 2024-03-23 14:17:26 UTC - remove indication that C string literals don't exist yet (rust-lang/edition-guide#295) ## rust-lang/reference 4 commits in 5afb503a4c1ea3c84370f8f4c08a1cddd1cdf6ad..984b36eca4b9293df04d5ba4eb5c4f77db0f51dc 2024-03-25 14:05:19 UTC to 2024-03-19 20:01:14 UTC - Fix typo of shebang (rust-lang/reference#1486) - Document importing `main` (rust-lang/reference#1461) - add grammar for `associated_type_bounds` in reference (rust-lang/reference#1481) - Literal expressions: fix mistake in the definition of unicode escapes (rust-lang/reference#1483) ## rust-lang/rust-by-example 1 commits in e093099709456e6fd74fecd2505fdf49a2471c10..7601e0c5ad29d5bd3b518700ea63fddfff5915a7 2024-03-17 21:37:25 UTC to 2024-03-17 21:37:25 UTC - Update enum_use.md to use a more neutral theme (rust-lang/rust-by-example#1828) ## rust-lang/rustc-dev-guide 12 commits in 8a5d647f19b08998612146b1cb2ca47083db63e0..ffa246b7fd95a96e1cd54883e613aed42c32547d 2024-03-23 07:44:42 UTC to 2024-03-11 18:17:28 UTC - [MCP 723] Rename AstConv to HIR ty lowering (rust-lang/rustc-dev-guide#1916) - add chapter to summary (rust-lang/rustc-dev-guide#1947) - document difference between solvers + new solver normalization (rust-lang/rustc-dev-guide#1945) - Fix broken link in chapter '1. How to build and run the compiler' (rust-lang/rustc-dev-guide#1946) - typo (rust-lang/rustc-dev-guide#1944) - Reflect rustc_codegen_cranelift move (rust-lang/rustc-dev-guide#1941) - Update rustdoc-internals.md (rust-lang/rustc-dev-guide#1911) - Update test-implementation.md (rust-lang/rustc-dev-guide#1937) - Extract Bootstrap into its own section (rust-lang/rustc-dev-guide#1939) - typos (rust-lang/rustc-dev-guide#1938) - More updates for recent diagnostics changes. (rust-lang/rustc-dev-guide#1936) - Update bibliography.md (rust-lang/rustc-dev-guide#1912)
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 26, 2024
Rollup merge of rust-lang#123039 - rustbot:docs-update, r=ehuss Update books ## rust-lang/edition-guide 1 commits in e1eead1181a691e56299294d5f1d62fe7a26d317..98b33e9a441457b0a491fe1be90e7de64eafc3e5 2024-03-23 14:17:26 UTC to 2024-03-23 14:17:26 UTC - remove indication that C string literals don't exist yet (rust-lang/edition-guide#295) ## rust-lang/reference 4 commits in 5afb503a4c1ea3c84370f8f4c08a1cddd1cdf6ad..984b36eca4b9293df04d5ba4eb5c4f77db0f51dc 2024-03-25 14:05:19 UTC to 2024-03-19 20:01:14 UTC - Fix typo of shebang (rust-lang/reference#1486) - Document importing `main` (rust-lang/reference#1461) - add grammar for `associated_type_bounds` in reference (rust-lang/reference#1481) - Literal expressions: fix mistake in the definition of unicode escapes (rust-lang/reference#1483) ## rust-lang/rust-by-example 1 commits in e093099709456e6fd74fecd2505fdf49a2471c10..7601e0c5ad29d5bd3b518700ea63fddfff5915a7 2024-03-17 21:37:25 UTC to 2024-03-17 21:37:25 UTC - Update enum_use.md to use a more neutral theme (rust-lang/rust-by-example#1828) ## rust-lang/rustc-dev-guide 12 commits in 8a5d647f19b08998612146b1cb2ca47083db63e0..ffa246b7fd95a96e1cd54883e613aed42c32547d 2024-03-23 07:44:42 UTC to 2024-03-11 18:17:28 UTC - [MCP 723] Rename AstConv to HIR ty lowering (rust-lang/rustc-dev-guide#1916) - add chapter to summary (rust-lang/rustc-dev-guide#1947) - document difference between solvers + new solver normalization (rust-lang/rustc-dev-guide#1945) - Fix broken link in chapter '1. How to build and run the compiler' (rust-lang/rustc-dev-guide#1946) - typo (rust-lang/rustc-dev-guide#1944) - Reflect rustc_codegen_cranelift move (rust-lang/rustc-dev-guide#1941) - Update rustdoc-internals.md (rust-lang/rustc-dev-guide#1911) - Update test-implementation.md (rust-lang/rustc-dev-guide#1937) - Extract Bootstrap into its own section (rust-lang/rustc-dev-guide#1939) - typos (rust-lang/rustc-dev-guide#1938) - More updates for recent diagnostics changes. (rust-lang/rustc-dev-guide#1936) - Update bibliography.md (rust-lang/rustc-dev-guide#1912)
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Mar 26, 2024
Update books ## rust-lang/edition-guide 1 commits in e1eead1181a691e56299294d5f1d62fe7a26d317..98b33e9a441457b0a491fe1be90e7de64eafc3e5 2024-03-23 14:17:26 UTC to 2024-03-23 14:17:26 UTC - remove indication that C string literals don't exist yet (rust-lang/edition-guide#295) ## rust-lang/reference 4 commits in 5afb503a4c1ea3c84370f8f4c08a1cddd1cdf6ad..984b36eca4b9293df04d5ba4eb5c4f77db0f51dc 2024-03-25 14:05:19 UTC to 2024-03-19 20:01:14 UTC - Fix typo of shebang (rust-lang/reference#1486) - Document importing `main` (rust-lang/reference#1461) - add grammar for `associated_type_bounds` in reference (rust-lang/reference#1481) - Literal expressions: fix mistake in the definition of unicode escapes (rust-lang/reference#1483) ## rust-lang/rust-by-example 1 commits in e093099709456e6fd74fecd2505fdf49a2471c10..7601e0c5ad29d5bd3b518700ea63fddfff5915a7 2024-03-17 21:37:25 UTC to 2024-03-17 21:37:25 UTC - Update enum_use.md to use a more neutral theme (rust-lang/rust-by-example#1828) ## rust-lang/rustc-dev-guide 12 commits in 8a5d647f19b08998612146b1cb2ca47083db63e0..ffa246b7fd95a96e1cd54883e613aed42c32547d 2024-03-23 07:44:42 UTC to 2024-03-11 18:17:28 UTC - [MCP 723] Rename AstConv to HIR ty lowering (rust-lang/rustc-dev-guide#1916) - add chapter to summary (rust-lang/rustc-dev-guide#1947) - document difference between solvers + new solver normalization (rust-lang/rustc-dev-guide#1945) - Fix broken link in chapter '1. How to build and run the compiler' (rust-lang/rustc-dev-guide#1946) - typo (rust-lang/rustc-dev-guide#1944) - Reflect rustc_codegen_cranelift move (rust-lang/rustc-dev-guide#1941) - Update rustdoc-internals.md (rust-lang/rustc-dev-guide#1911) - Update test-implementation.md (rust-lang/rustc-dev-guide#1937) - Extract Bootstrap into its own section (rust-lang/rustc-dev-guide#1939) - typos (rust-lang/rustc-dev-guide#1938) - More updates for recent diagnostics changes. (rust-lang/rustc-dev-guide#1936) - Update bibliography.md (rust-lang/rustc-dev-guide#1912)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while writing this doc I realized some further improvements to normalization.
Also, this existing system is far more involved than I expected as large parts of it are intuition based for me. Will try to play a bit with our approach in the near future and then improve this guide further.
cc @rust-lang/initiative-trait-system-refactor