Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename librustc to librustc_middle #642

Merged
merged 5 commits into from
Mar 31, 2020

Conversation

LeSeulArtichaut
Copy link
Contributor

@LeSeulArtichaut LeSeulArtichaut commented Mar 30, 2020

This is a first draft of the changes. I wanted to use the CI to detect broken links as soon as the new nightly is pushed to doc.rust-lang.org.

  • Replaced occurences of librustc:: with librustc_middle:: (code paths)
  • Replaced occurences of librustc/ with librustc_middle/ (file paths)
  • Replaced occurences of /rustc/ with /rustc_middle/ (doc paths)

cc rust-lang/rust#70536

EDIT (mark-i-m): I've rolled up all of the link fixing PRs into this one, since none of them can individually pass CI.

resolves #640 #641 #646

@mark-i-m
Copy link
Member

It looks like the new rustdocs have not uploaded yet.

@mark-i-m
Copy link
Member

I've rolled together the other link fixes too.

@mark-i-m
Copy link
Member

cc @ecstatic-morse @anp @tshepang

@LeSeulArtichaut
Copy link
Contributor Author

LeSeulArtichaut commented Mar 31, 2020

Docs are now uploaded https://doc.rust-lang.org/nightly/nightly-rustc/rustc_middle/, re-running checks
EDIT: seems like I can't re-run the checks myself, ping @mark-i-m @spastorino

@JohnTitor
Copy link
Member

Re-triggered CI, seems some commit-specified links are broken.

@tshepang
Copy link
Member

@LeSeulArtichaut just a few failures left, which are links to exact commits. I think those you are must just revert.

mark-i-m
mark-i-m previously approved these changes Mar 31, 2020
Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks!

@mark-i-m mark-i-m merged commit 595f2f3 into rust-lang:master Mar 31, 2020
@LeSeulArtichaut LeSeulArtichaut deleted the rustc-middle branch April 1, 2020 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link to no-longer-extant has_any_child_of
5 participants