Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overview updates: parser #669

Closed

Conversation

chrissimpkins
Copy link
Member

@chrissimpkins chrissimpkins commented Apr 6, 2020

Do not merge into master.

Working branch for the Overview document in #633

@chrissimpkins chrissimpkins mentioned this pull request Apr 6, 2020
@LeSeulArtichaut LeSeulArtichaut added the S-blocked Status: this PR is blocked waiting for something label Apr 7, 2020
@chrissimpkins
Copy link
Member Author

@rust-lang/wg-rustc-dev-guide The detailed outline for the rustc_interface, lexer, and parser are ready for review as of b3e75e8.

Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This content is great ❤️! But I feel it is too detailed for the overview. We don't mention nearly so much info for any other part of the compiler, and my inclination is to say that we should move most of it to the parser/lexer chapter instead, with the overview having one bullet point on each major part of the compiler. e.g.

  • low-level lexer
  • high-level lexer
  • parser/AST
  • macro expansion, AST validation, name res, early linting

cc @rust-lang/wg-rustc-dev-guide I wonder what others think

@chrissimpkins
Copy link
Member Author

chrissimpkins commented Apr 8, 2020

No problem at all. I have a good outline now and can move it out of the Overview to start making sections in the chapter. What do you feel we should leave in the outline? One line summary and entry point?

@mark-i-m
Copy link
Member

mark-i-m commented Apr 8, 2020

@chrissimpkins I posted on zulip. I would really want to see what others in the WG think and try to come a consensus about how much detail to have in the overview.

@chrissimpkins
Copy link
Member Author

Sounds good. Won’t remove anything here yet.

@mark-i-m mark-i-m force-pushed the chrissimpkins-overview branch from b3e75e8 to d023ac7 Compare April 14, 2020 22:35
@mark-i-m
Copy link
Member

rebased

@mark-i-m
Copy link
Member

Merged into #633

@mark-i-m mark-i-m closed this Apr 14, 2020
@chrissimpkins chrissimpkins mentioned this pull request May 20, 2020
8 tasks
@chrissimpkins chrissimpkins deleted the chrissimpkins-overview branch May 28, 2020 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked Status: this PR is blocked waiting for something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants