-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overview updates: parser #669
Overview updates: parser #669
Conversation
@rust-lang/wg-rustc-dev-guide The detailed outline for the rustc_interface, lexer, and parser are ready for review as of b3e75e8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This content is great ❤️! But I feel it is too detailed for the overview. We don't mention nearly so much info for any other part of the compiler, and my inclination is to say that we should move most of it to the parser/lexer chapter instead, with the overview having one bullet point on each major part of the compiler. e.g.
- low-level lexer
- high-level lexer
- parser/AST
- macro expansion, AST validation, name res, early linting
cc @rust-lang/wg-rustc-dev-guide I wonder what others think
No problem at all. I have a good outline now and can move it out of the Overview to start making sections in the chapter. What do you feel we should leave in the outline? One line summary and entry point? |
@chrissimpkins I posted on zulip. I would really want to see what others in the WG think and try to come a consensus about how much detail to have in the overview. |
Sounds good. Won’t remove anything here yet. |
Co-Authored-By: Centril <twingoow@gmail.com>
Co-Authored-By: LeSeulArtichaut <leseulartichaut@gmail.com>
Co-Authored-By: LeSeulArtichaut <leseulartichaut@gmail.com>
Co-Authored-By: LeSeulArtichaut <leseulartichaut@gmail.com>
Co-Authored-By: Centril <twingoow@gmail.com>
Co-Authored-By: Santiago Pastorino <spastorino@gmail.com>
Co-Authored-By: LeSeulArtichaut <leseulartichaut@gmail.com>
includes feedback from matklad (lexer) and centril (parser)
b3e75e8
to
d023ac7
Compare
rebased |
Merged into #633 |
Do not merge into master.
Working branch for the Overview document in #633