const fn-ify what can be const of the API
#31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps to remove lazy initialization to initialize global static variables containing `FxHashMap`/`FxHashSet`.
nnethercote
reviewed
Feb 29, 2024
| FxHasher { hash: seed } | ||
| } | ||
|
|
||
| /// Create a default `fq` hasher. |
There was a problem hiding this comment.
Also: what's the point of creating a default function in this impl when Default is already impl'd? I'm actually surprised this even works.
There was a problem hiding this comment.
The point is that it can be const. I think a different name would be nicer though.
There was a problem hiding this comment.
Default is not a #[const_trait] yet and feature const_trait_impl/effects is still very much WIP. The inherent associated function default can be used in const contexts contrary to the trait associated function. Inherent associated items have precedence over their trait counterpart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps to remove lazy initialization to initialize global static variables containing
FxHashMap/FxHashSet.