Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI with proper test jobs + fmt/doc/clippy #48

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Improve CI with proper test jobs + fmt/doc/clippy #48

merged 3 commits into from
Jul 18, 2024

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Jul 17, 2024

@Urgau Urgau requested a review from Noratrieb July 17, 2024 11:03
@MarcoIeni MarcoIeni mentioned this pull request Jul 17, 2024
Closed
3 tasks
@MarcoIeni
Copy link
Member

Hey, thanks for your help! 🙏 I linked this PR in the issue so that we can track it 👍

@WaffleLapkin
Copy link
Member

Why are different jobs so different in how they get the toolchain? i.e. some some just use default, some use update first, some use install...

@Urgau
Copy link
Member Author

Urgau commented Jul 18, 2024

No particular reason, it just happened over time, as they were not added at the same time.

They should probably all use the update+default invocation, except for miri where we can't just use the "shorthand" update since it doesn't support adding component, so we use the full rustup toolchain invocation.

@WaffleLapkin WaffleLapkin merged commit e1b3727 into rust-lang:master Jul 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WaffleLapkin WaffleLapkin WaffleLapkin approved these changes

@Noratrieb Noratrieb Awaiting requested review from Noratrieb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Urgau @MarcoIeni @WaffleLapkin