Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH perf bot missing perf builds message completely for rollup #1424

Closed
klensy opened this issue Aug 25, 2022 · 3 comments · Fixed by #1426
Closed

GH perf bot missing perf builds message completely for rollup #1424

klensy opened this issue Aug 25, 2022 · 3 comments · Fixed by #1426

Comments

@klensy
Copy link
Contributor

klensy commented Aug 25, 2022

rust-lang/rust#100977 is rollup of 8, but no perf builds message, like in rust-lang/rust#100963 (comment).

Probably because of rustc_codegen_cranelift sync with lots things in it.

Similar to #1390

@rylev
Copy link
Member

rylev commented Aug 25, 2022

👀 The webhook was successful which means the error happened when we're processing it in the background. I'll need to jump into the logs to find out more.

@rylev
Copy link
Member

rylev commented Aug 26, 2022

Here's the successfully created unrolled PR comment: rust-lang/rust#100977 (comment).

You'll notice that two of the PRs could not be unrolled due to merge conflicts (which is why this was originally not working).

@rylev
Copy link
Member

rylev commented Aug 26, 2022

Looking at things more closely, it turns out that the mechanism mistakenly found 2 rollup merge commits because one of the rollup PRs itself contained rollup merge commits. Unfortunately, I'm pretty sure there's no way for us to detect that in our current approach due to the issue found in #1390.

The way to solve this is to follow the commit tree directly instead of using the Push payload to try to determine the right set of commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants