Rollup of 8 pull requests #100977

JohnTitor · 2022-08-24T23:51:03Z

Successful merges:

Stabilize #![feature(label_break_value)] #99332 (Stabilize #![feature(label_break_value)])
let-else: break out to one scope higher for let-else #99954 (let-else: break out to one scope higher for let-else)
Parser will not suggest invalid expression when use public #100188 (Parser will not suggest invalid expression when use public)
save_analysis: Migrate diagnostic #100780 (save_analysis: Migrate diagnostic)
Migrate rustc_interface diagnostics #100808 (Migrate rustc_interface diagnostics )
Add a warning about Option/Result::and() being eagerly evaluated #100921 (Add a warning about Option/Result::and() being eagerly evaluated)
rustdoc: ayu code color selector more specific #100960 (rustdoc: ayu code color selector more specific)
Sync rustc_codegen_cranelift #100964 (Sync rustc_codegen_cranelift)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

…ister Enable raw-dylib for bin crates Fixes rust-lang#93842 When `raw-dylib` is used in a `bin` crate, we need to collect all of the `raw-dylib` functions, generate the import library and add that to the linker command line. I also changed the tests so that 1) the C++ dlls are created after the Rust dlls, thus there is no chance of accidentally using them in the Rust linking process and 2) disabled generating import libraries when building with MSVC.

Rollup of 7 pull requests Successful merges: - rust-lang#98211 (Implement `fs::get_path` for FreeBSD.) - rust-lang#99353 (Slightly improve mismatched GAT where clause error) - rust-lang#99593 (Suggest removing the tuple struct field for the unwrapped value) - rust-lang#99615 (Remove some explicit `self.infcx` for `FnCtxt`, which already derefs into `InferCtxt`) - rust-lang#99711 (Remove reachable coverage without counters) - rust-lang#99718 (Avoid `&str`/`Symbol` to `String` conversions) - rust-lang#99720 (Sync rustc_codegen_cranelift) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

…clif-2022-07-26

This avoids monomorphizing all linker code for each codegen backend and will allow passing in extra information to the archive builder from the codegen backend.

This is probably the wrong way to do this...

This avoids differences in line endings.

Move test script to y.rs

…JohnTitor Add a warning about `Option/Result::and()` being eagerly evaluated Copied from `or()`. Inspired by [this StackOverflow question](https://stackoverflow.com/questions/73461846/why-is-in-rust-the-expression-in-option-and-evaluated-if-option-is-none). [The PR for `or()`](rust-lang#46548) mentions the Clippy lint `or_fun_call` which doesn't exist for `and()` (although there is `unnecessary_lazy_evaluations`). I still think this warning is also good for `and()`. Feel free to close if you disagree.

… r=GuillaumeGomez rustdoc: ayu code color selector more specific According to rust-lang#100960 (comment), this selector is only really intended to apply to item info. However, it's so broad that it's hard to tell when it deliberately applies vs where it accidentally applies.

…bjorn3 Sync rustc_codegen_cranelift The main highlights this time are support for parallel compilation of codegen units (by me) and improved windows support (by ``@afonso360)`` In addition ``@afonso360`` added abi-checker to cg_clif's CI. This has already catched an abi compatibility issue with AArch64. The fix has landed on Cranelift's main branch, but doesn't yet have a release. ``@uweigand`` also submitted a couple of PR's that will are prerequisites for supporting IBM's s390x architecture. r? ``@ghost`` ``@rustbot`` label +A-codegen +A-cranelift +T-compiler

JohnTitor · 2022-08-24T23:51:11Z

@bors r+ p=8 rollup=never

bors · 2022-08-24T23:51:12Z

📌 Commit f2878a6 has been approved by JohnTitor

It is now in the queue for this repository.

bors · 2022-08-25T02:32:15Z

⌛ Testing commit f2878a6 with merge 9b9bc63...

bors · 2022-08-25T05:13:16Z

☀️ Test successful - checks-actions
Approved by: JohnTitor
Pushing 9b9bc63 to master...

rust-timer · 2022-08-25T07:37:16Z

Finished benchmarking commit (9b9bc63): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	4.6%	[4.0%, 5.3%]	4
Regressions ❌ (secondary)	3.7%	[2.4%, 4.6%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-6.1%	[-6.1%, -6.1%]	1
All ❌✅ (primary)	4.6%	[4.0%, 5.3%]	4

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.6%	[2.1%, 4.7%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.5%	[-3.5%, -3.5%]	1
All ❌✅ (primary)	-	-	0

the arithmetic mean of the percent change ↩ ↩²
number of relevant changes ↩ ↩²

rust-timer · 2022-08-26T10:00:17Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#100964	75be8e04f6e54468575c13c51412a89e378d9b25
#100960	eba85637be6912e3a54511846b018bfc46aa41dc
#100921	92b38b421cbc31265d38fae17aea25c12cc466a6
#100808	c32d7d7e3a9947dc8eee15a94971397bb0b6ad94
#100780	f5b7cf175921c853dcdc7556d04b920dca80253a
#100188	4726076dd070f64d8b09787a40d4a4dd88a3a60c
#99954	135777df349bd8c60ed4d8d84d2e41e3167c31fa
#99332	e91a59fb6bab5e8cd1581a71715e18694b6d95a9
#100822	❌ conflicts merging 'bd1ab72406' into previous master ❌
#100208	❌ conflicts merging '8520535694' into previous master ❌

previous master: 5462da52ba

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

dpaoliello and others added 30 commits July 22, 2022 09:55

Enable raw-dylib for binaries

0fed1a5

Merge commit 'd3a2366ee877075c59b38bd8ced55f224fc7ef51' into sync_cg_…

a6260ec

…clif-2022-07-26

Merge branch 'sync_from_rust'

72c69a8

Rustup to rustc 1.64.0-nightly (4d6d601 2022-07-26)

e34bb03

Move output argument from ArchiveBuilder::new to .build()

e0697a3

Inline inject_dll_import_lib

34b37e7

Introduce an ArchiveBuilderBuilder

451817e

This avoids monomorphizing all linker code for each codegen backend and will allow passing in extra information to the archive builder from the codegen backend.

Update to cranelift 0.86 (rust-lang#1250)

49e7731

Add Windows build artifacts to .gitignore

6fd1660

Move test.sh to y.rs test

3ce83dc

Run tests on windows CI

c115933

Misc cleanups to the test runner

d059935

Use get_file_name everywhere for better cross compilation support

437b441

Use get_file_name in tests

ae4fe1d

break out to one scope higher for let-else

0244355

Use Windows Env vars in CI

aa2f407

Fix test.regex test

8ec3d20

Fix aarch64 cross compilation

f8747f0

Fix some cross compilation scenarios in test runner

3936134

Split flags whitespace

6ea108b

This is probably the wrong way to do this...

Log cloned regex output

78372d6

Compare lines iterator instead of full output

bec651e

This avoids differences in line endings.

Cleanup meaningless changes

2f13800

Don't run tests on Windows CI

5d79366

Assume host target in get_file_name

f588bfa

Don't pass RUSTFLAGS to rustc in tests

d489fb9

Rustfmt

0db9094

Merge pull request rust-lang#1252 from afonso360/tests-rs

231f7c6

Move test script to y.rs

JohnTitor added 3 commits August 25, 2022 08:50

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 24, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 25, 2022

bors merged commit 9b9bc63 into rust-lang:master Aug 25, 2022

rustbot added this to the 1.65.0 milestone Aug 25, 2022

klensy mentioned this pull request Aug 25, 2022

GH perf bot missing perf builds message completely for rollup rust-lang/rustc-perf#1424

Closed

davidtwco removed the A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic label Oct 4, 2022

JohnTitor deleted the rollup-8hc7rxh branch June 25, 2023 14:33

matthiaskrgr mentioned this pull request Aug 4, 2023

ICE: broken mir with -Zprint-mono-items=eager between passes RemoveStorageMarkers and Inline #114458

Closed

matthiaskrgr mentioned this pull request Dec 18, 2023

MIR validation ICE: Use of local which has no storage #118990

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #100977

Rollup of 8 pull requests #100977

JohnTitor commented Aug 24, 2022

JohnTitor commented Aug 24, 2022

bors commented Aug 24, 2022

bors commented Aug 25, 2022

bors commented Aug 25, 2022

rust-timer commented Aug 25, 2022

rust-timer commented Aug 26, 2022

Rollup of 8 pull requests #100977

Rollup of 8 pull requests #100977

Conversation

JohnTitor commented Aug 24, 2022

JohnTitor commented Aug 24, 2022

bors commented Aug 24, 2022

bors commented Aug 25, 2022

bors commented Aug 25, 2022

rust-timer commented Aug 25, 2022

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

rust-timer commented Aug 26, 2022