Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name bin target differently from lib #1122

Merged
merged 1 commit into from
Dec 18, 2021

Conversation

Mark-Simulacrum
Copy link
Member

This avoids file collisions, which lead to spurious rebuilds and errors from
Cargo (recently added by rust-lang/cargo#10172).

I haven't been able to confirm this locally yet, possibly because the wrong
Cargo gets used (not sure), but this should hopefully fix the benchmark on perf.r-l.o.

@Mark-Simulacrum
Copy link
Member Author

This avoids clobbering the output (good, I guess) but still runs into the same problem. Discussing on https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/document.20lib.20before.20bin.

This avoids file collisions, which lead to spurious rebuilds and errors from
Cargo (recently added by rust-lang/cargo#10172).
@Mark-Simulacrum
Copy link
Member Author

rust-lang/cargo#10201 should let us move forward here once a Cargo bump including it lands on rust-lang/rust.

@Mark-Simulacrum Mark-Simulacrum merged commit 9d8903f into rust-lang:master Dec 18, 2021
@Mark-Simulacrum Mark-Simulacrum deleted the fix-bench branch December 18, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant