Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add absolute chart to benchmark details #1729

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

lqd
Copy link
Member

@lqd lqd commented Sep 28, 2023

This PR adds an absolute chart to the benchmark detail panel, to complement the relative chart:

  • the relative chart easily shows cyclical noise, and the common magnitude seen on a given benchmark
  • the absolute chart easily shows whether a change was noise and has returned to steady state, or is real and has stayed the same since the commit.

Screenshot

image

@lqd lqd force-pushed the double-graphs-all-the-way branch from 2f0eba4 to 7d7af10 Compare September 28, 2023 21:25
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, I like the horizontal layout and the fact that the graphs are both visible at once.

For me, they render below each other though:
image

@lqd lqd force-pushed the double-graphs-all-the-way branch from 7d7af10 to b873b61 Compare October 2, 2023 08:01
@lqd
Copy link
Member Author

lqd commented Oct 2, 2023

I also reduced the graph width a bit so that both should fit in a single row consistently, which should fix the issue in your screenshot.

@Kobzol
Copy link
Contributor

Kobzol commented Oct 2, 2023

image
😅 I would just remove flex-wrap: wrap for this particular graphs wrapper div.

Also, I think that we should introduce a new API endpoint that will return all data necessary for the benchmark detail (I'll like to add some more data to it in the future), as we now make two API calls per opened row. But let's not do that in this PR, I'll do it in a follow-up.

@lqd lqd force-pushed the double-graphs-all-the-way branch from b873b61 to 627d02e Compare October 2, 2023 17:44
@lqd
Copy link
Member Author

lqd commented Oct 2, 2023

Actually incredible. I pushed a nowrap, and hope it works for you because 3rd time's the charm.

Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lqd lqd force-pushed the double-graphs-all-the-way branch from 627d02e to 5027828 Compare October 2, 2023 19:02
@lqd lqd merged commit 53282c1 into rust-lang:master Oct 2, 2023
9 checks passed
@lqd lqd deleted the double-graphs-all-the-way branch October 2, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants