-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Send bounds from scopes. #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably reconsider this upstream -- see rayon-rs#562. Can you also add some description motivating this change in your case?
where | ||
FUNC: FnOnce() -> R, | ||
{ | ||
let result = self.execute_job_closure(func); | ||
self.steal_till_jobs_complete(owner_thread); | ||
in_worker(|owner_thread, _| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems unfortunate to inject yet another job just to wait for completion. Maybe we could add another latch type that acts like a combination of CountLatch
and LockLatch
, raising the Condvar
when the count is zero. Then job_completed_latch
would need to be an enum of either CountLatch
or this new thing, depending on what context it's called from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't matter for rustc, since it always runs in a worker.
I want to run some code which refers to |
Closing this pull request as Zoxc is stepping back from compiler development; see rust-lang/team#316. |
No description provided.