Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc-codegen-cranelift-preview support for aarch64-apple-darwin #1502

Closed
yerke opened this issue Jun 24, 2024 · 3 comments · Fixed by rust-lang/rust#127177
Closed

rustc-codegen-cranelift-preview support for aarch64-apple-darwin #1502

yerke opened this issue Jun 24, 2024 · 3 comments · Fixed by rust-lang/rust#127177
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. O-macos Operating system: MacOS

Comments

@yerke
Copy link

yerke commented Jun 24, 2024 •
edited
Loading

After the recent announcement for fixes for Apple Silicon I tried to install rustc-codegen-cranelift-preview component by following the instructions in the readme, but got an error.

> rustup component add rustc-codegen-cranelift-preview --toolchain nightly
error: component 'rustc-codegen-cranelift' for target 'aarch64-apple-darwin' is unavailable for download for channel 'nightly'
Sometimes not all components are available in any given nightly.

Am I doing something wrong or is the current nightly channel currently missing something? I have nightly-aarch64-apple-darwin (3cb521a43 2024-06-22).

Edit: Oh, I just saw that the footnote still applies: Not available as rustup component for nightly. You can build it yourself..

I guess my question now is the following: is there anything preventing adding rustc-codegen-cranelift-preview rustup component for aarch64-apple-darwin?

Thanks!
@bjorn3
Copy link
Member

bjorn3 commented Jun 24, 2024

I would prefer to see bytecodealliance/wasmtime#8730 fixed first. Without it you need to switch back to the old linker on arm64 macOS if you use XCode 15 or later.

@yerke
Copy link
Author

yerke commented Jun 24, 2024

Got it. RUSTFLAGS="-Clink-arg=-ld_classic" worked for me.

@bjorn3
Copy link
Member

bjorn3 commented Jun 30, 2024 •
edited
Loading

bytecodealliance/wasmtime#8730 has been fixed. Opened a subtree sync PR and will open a PR to distribute cg_clif as rustup component for arm64 macOS once it merges.

Edit: rust-lang/rust#127177

@bjorn3 bjorn3 added C-enhancement Category: An issue proposing an enhancement or a PR with one. O-macos Operating system: MacOS labels Jun 30, 2024
@bjorn3 bjorn3 mentioned this issue Jul 1, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jul 20, 2024
@matthiaskrgr
Rollup merge of rust-lang#127177 - bjorn3:arm64_macos_cg_clif, r=Mark…
ef5b297 
…-Simulacrum

Distribute rustc_codegen_cranelift for arm64 macOS

Support for arm64 macOS has been added to rustc_codegen_cranelift recently.

Fixes rust-lang/rustc_codegen_cranelift#1502
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jul 20, 2024
@matthiaskrgr
Rollup merge of rust-lang#127177 - bjorn3:arm64_macos_cg_clif, r=Mark…
7834513 
…-Simulacrum

Distribute rustc_codegen_cranelift for arm64 macOS

Support for arm64 macOS has been added to rustc_codegen_cranelift recently.

Fixes rust-lang/rustc_codegen_cranelift#1502
compiler-errors added a commit to compiler-errors/rust that referenced this issue Jul 20, 2024
@compiler-errors
Rollup merge of rust-lang#127177 - bjorn3:arm64_macos_cg_clif, r=Mark…
60684d2 
…-Simulacrum

Distribute rustc_codegen_cranelift for arm64 macOS

Support for arm64 macOS has been added to rustc_codegen_cranelift recently.

Fixes rust-lang/rustc_codegen_cranelift#1502
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jul 21, 2024
@matthiaskrgr
Rollup merge of rust-lang#127177 - bjorn3:arm64_macos_cg_clif, r=Mark…
810122b 
…-Simulacrum

Distribute rustc_codegen_cranelift for arm64 macOS

Support for arm64 macOS has been added to rustc_codegen_cranelift recently.

Fixes rust-lang/rustc_codegen_cranelift#1502
tgross35 added a commit to tgross35/rust that referenced this issue Jul 21, 2024
@tgross35
Rollup merge of rust-lang#127177 - bjorn3:arm64_macos_cg_clif, r=Mark…
0b53d3f 
…-Simulacrum

Distribute rustc_codegen_cranelift for arm64 macOS

Support for arm64 macOS has been added to rustc_codegen_cranelift recently.

Fixes rust-lang/rustc_codegen_cranelift#1502
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jul 21, 2024
@GuillaumeGomez
Rollup merge of rust-lang#127177 - bjorn3:arm64_macos_cg_clif, r=Mark…
14a89ab 
…-Simulacrum

Distribute rustc_codegen_cranelift for arm64 macOS

Support for arm64 macOS has been added to rustc_codegen_cranelift recently.

Fixes rust-lang/rustc_codegen_cranelift#1502
jieyouxu added a commit to jieyouxu/rust that referenced this issue Jul 22, 2024
@jieyouxu
Rollup merge of rust-lang#127177 - bjorn3:arm64_macos_cg_clif, r=Mark…
b66b402 
…-Simulacrum

Distribute rustc_codegen_cranelift for arm64 macOS

Support for arm64 macOS has been added to rustc_codegen_cranelift recently.

Fixes rust-lang/rustc_codegen_cranelift#1502
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jul 22, 2024
@rust-timer
Unrolled build for rust-lang#127177
3e42db1 
Rollup merge of rust-lang#127177 - bjorn3:arm64_macos_cg_clif, r=Mark-Simulacrum

Distribute rustc_codegen_cranelift for arm64 macOS

Support for arm64 macOS has been added to rustc_codegen_cranelift recently.

Fixes rust-lang/rustc_codegen_cranelift#1502
@bjorn3 bjorn3 closed this as completed in f85d741 Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. O-macos Operating system: MacOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Distribute rustc_codegen_cranelift for arm64 macOS bjorn3/rust
2 participants
@yerke @bjorn3