Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass preserve_frame_pointers to Cranelift #1388

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jul 29, 2023

I don't know how to test this :)

Closes: https://github.com/bjorn3/rustc_codegen_cranelift/issues/1246

@bjorn3
Copy link
Member

bjorn3 commented Jul 29, 2023

Thanks! I've confirmed this works for AArch64. Without -Cforce-frame-pointers I get:

00000000000027a4 <_ZN21mini_core_hello_world8take_f3217ha03ff4b464fa7475E>:
    27a4:       d65f03c0        ret

and with I get:

00000000000027bc <_ZN21mini_core_hello_world8take_f3217ha03ff4b464fa7475E>:
    27bc:       a9bf7bfd        stp     x29, x30, [sp, #-16]!
    27c0:       910003fd        mov     x29, sp
    27c4:       a8c17bfd        ldp     x29, x30, [sp], #16
    27c8:       d65f03c0        ret

@bjorn3 bjorn3 merged commit 85a99b3 into rust-lang:master Jul 29, 2023
16 checks passed
@Kobzol Kobzol deleted the preserve-frame-pointer branch July 29, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use preserve_frame_pointers cranelift flag as necessary
2 participants