Remove libgccjit patches to not have them in rustc repository #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Jul 18, 2021
| @@ -1,5 +1,7 @@ | |||
| #!/bin/bash | |||
|
|
|||
| # TODO: rewrite to cargo-make or something like that to only rebuild the sysroot when needed? | |||
There was a problem hiding this comment.
cg_clif has a config.txt file with a keep_sysroot option that I can quickly enable.
|
Merging as is. |
|
Apologies for the delay, forwarding this to our counsel now. |
|
@nellshamrell As a note, the git commit history has been squashed in my PR in rustc, so those patches will never show up in the git history. |
|
@antoyo our counsel confirms that without the patches there's no need to include the NOTICE note or a copy of the GPLv3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the patches are being removed from this repository, I removed the note in the NOTICE file and the copy of the GPLv3 license.
@nellshamrell: Please tell me if this is ok. Thanks!