-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR 3223 should be gated on the version number #3229
Labels
bug
Panic, non-idempotency, invalid code, etc.
Comments
@nrc what should be done to fix this ? |
Ouch. I forgot about versioning thing when I merged it... 😭 @scampi We need to address the following things:
if config.version() == Version::One {
// format in old way
} else {
// format in new way
}
|
@nrc @topecongiro sorry about that, i've been reading posts about rustfmt stabilisation but it didn't strike me either when writing the PR. |
scampi
added a commit
to scampi/rustfmt
that referenced
this issue
Dec 19, 2018
scampi
added a commit
to scampi/rustfmt
that referenced
this issue
Dec 19, 2018
scampi
added a commit
to scampi/rustfmt
that referenced
this issue
Dec 19, 2018
scampi
added a commit
to scampi/rustfmt
that referenced
this issue
Dec 19, 2018
topecongiro
added a commit
that referenced
this issue
Dec 20, 2018
Clarify version gate used for #3229
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: