Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unstable option] binop_separator #3368

Open
Tracked by #1895
scampi opened this issue Feb 13, 2019 · 3 comments · Fixed by #4144 · May be fixed by #5549
Open
Tracked by #1895

[unstable option] binop_separator #3368

scampi opened this issue Feb 13, 2019 · 3 comments · Fixed by #4144 · May be fixed by #5549
Labels
unstable option tracking issue of an unstable option
Milestone
2.0.0

Comments

@scampi
Copy link
Contributor

scampi commented Feb 13, 2019

Tracking issue for unstable option: binop_separator
@scampi scampi added the unstable option tracking issue of an unstable option label Feb 13, 2019
@scampi scampi changed the title [unstable option] unstable option: binop_separator [unstable option] binop_separator Feb 18, 2019
@aloucks
Copy link
Contributor

aloucks commented Jun 9, 2019

Are there any unresolved questions or work needed for this option to be stabilized?

@emilio
Copy link
Contributor

emilio commented Apr 30, 2020

Please consider stabilizing this? Servo has been using it since forever, and it's been stable as far as I can tell.

If there's no issue with this option it'd be nice to be able to use stable rustfmt.

@emilio emilio mentioned this issue Apr 30, 2020
Merged
emilio added a commit to emilio/rustfmt that referenced this issue Apr 30, 2020
@emilio
Stabilize binop_separator.
a344e66 
Servo has used this since forever, and it'd be useful to be able to use
rustfmt stable there so that we can use the same rustfmt version in
both Firefox and Servo.

Feel free to close this if there's any reason it shouldn't be done.

Closes rust-lang#3368
@calebcartwright calebcartwright added this to the 2.0.0 milestone May 7, 2020
calebcartwright pushed a commit that referenced this issue May 8, 2020
@emilio @calebcartwright
Stabilize binop_separator.
c83e729 
Servo has used this since forever, and it'd be useful to be able to use
rustfmt stable there so that we can use the same rustfmt version in
both Firefox and Servo.

Feel free to close this if there's any reason it shouldn't be done.

Closes #3368
bradleypmartin pushed a commit to bradleypmartin/rustfmt that referenced this issue May 25, 2020
@emilio
Stabilize binop_separator.
445f71e 
Servo has used this since forever, and it'd be useful to be able to use
rustfmt stable there so that we can use the same rustfmt version in
both Firefox and Servo.

Feel free to close this if there's any reason it shouldn't be done.

Closes rust-lang#3368
@karyon
Copy link
Contributor

karyon commented Nov 14, 2021

This will need to be re-done for 1.x

@karyon karyon reopened this Nov 14, 2021
emilio added a commit to emilio/rustfmt that referenced this issue Sep 28, 2022
@emilio
config: Stabilize binop_separator again.
876e29e 
See reasoning in rust-lang#4144, which still applies. Other projects like bindgen
etc also use it by default, and this would allow them to move to stable
rust.

Fixes rust-lang#3368 again.
@emilio emilio linked a pull request Sep 28, 2022 that will close this issue
Open
emilio added a commit to emilio/rustfmt that referenced this issue Dec 19, 2022
@emilio
config: Stabilize binop_separator again.
c2dcf8b 
See reasoning in rust-lang#4144, which still applies. Other projects like bindgen
etc also use it by default, and this would allow them to move to stable
rust.

Fixes rust-lang#3368 again.
emilio added a commit to emilio/rustfmt that referenced this issue Nov 20, 2023
@emilio
config: Stabilize binop_separator again.
032421a 
See reasoning in rust-lang#4144, which still applies. Other projects like bindgen
etc also use it by default, and this would allow them to move to stable
rust.

Fixes rust-lang#3368 again.
@mattheworris mattheworris mentioned this issue Feb 28, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
unstable option tracking issue of an unstable option
Projects
None yet
Milestone
2.0.0
5 participants
@aloucks @scampi @emilio @karyon @calebcartwright