Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Planned removal of report_fixme #5102

Closed
calebcartwright opened this issue Nov 22, 2021 · 1 comment · Fixed by #5357
Closed

Planned removal of report_fixme #5102

calebcartwright opened this issue Nov 22, 2021 · 1 comment · Fixed by #5357
Assignees
@calebcartwright

Comments

@calebcartwright
Copy link
Member

The purpose of this issue is to both communicate our intent to drop the unstable option report_fixme, as well as provide a forum for questions to be asked and/or concerns to be raised.

We do not yet have an exact deprecation date planned, but it will most likely occur in early 2022.

While we understand the utility this option provides, we've decided that rustfmt simply is not the right place/tool to provide this capability, and it's not an option that makes sense for us to try to stabilize and maintain/support long term.

If anyone is aware of any other community maintained tools/crates for detecting "FIXME" strings in comments please feel free to post here for broader awareness.
@calebcartwright calebcartwright pinned this issue Nov 22, 2021
@calebcartwright calebcartwright self-assigned this Nov 22, 2021
@calebcartwright calebcartwright mentioned this issue Nov 22, 2021
Closed
This was referenced Dec 4, 2021
Closed
Closed
@orenbenkiki
Copy link

I agree that this functionality does not belong in rustfmt. I have been using cargo-todox instead of report_fixme, which might be something of an overkill (I did it as a way to get started with Rust back in the day). Alternatively people could just run grep FIXME $(git ls-files) or something along these lines.

@ytmimi ytmimi mentioned this issue Mar 31, 2022
Merged
This was referenced May 30, 2022
Closed
Merged
googolmo added a commit to googolmo/rings-node that referenced this issue Jul 1, 2022
@googolmo
remove report_fixme configuration in rustfmt
d78bbe3 
rust-lang/rustfmt#5102
googolmo added a commit to RingsNetwork/rings that referenced this issue Jul 4, 2022
@googolmo
upgrade rust-toolchain to nightly-2022-06-27 (#201)
ec5b489 
* upgrade rust-toolchain to nightly-2022-06-27

* remove `report_fixme` configuration in rustfmt

rust-lang/rustfmt#5102
@ascjones ascjones mentioned this issue Jul 5, 2022
Merged
@DeltaF1 DeltaF1 mentioned this issue Dec 15, 2022
Closed
@calebcartwright calebcartwright unpinned this issue Dec 20, 2022
@SWvheerden SWvheerden mentioned this issue Feb 1, 2023
Merged
stringhandler pushed a commit to tari-project/tari that referenced this issue Feb 1, 2023
@SWvheerden
chore: fix cargo fmt (#5159)
603cb1f 
Description
---
Removes unused cargo fmt options

Motivation and Context
---
Since [[1.5.0] 2022-06-14](https://github.com/rust-lang/rustfmt/blob/1d8491b120223272b13451fc81265aa64f7f4d5b/CHANGELOG.md#150-2022-06-14) the options `report_todo` and `report_fixme`  have been removed,  [5101](rust-lang/rustfmt#5101) and [5102](rust-lang/rustfmt#5102)

How Has This Been Tested?
---
Manual 
Cargo fmt does not complain about: 
```
Warning: Unknown configuration option `report_fixme`
Warning: Unknown configuration option `report_todo`
```
@tareknaser tareknaser mentioned this issue Feb 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@calebcartwright calebcartwright

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove some unstable config options that've been deprecated calebcartwright/rustfmt
2 participants
@orenbenkiki @calebcartwright