add support for --message-format option in cargo fmt
#3752
Merged
+152
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3274
--message-format
in the othercargo
subcommands accepts 3 values:In the context of rustfmt, my thinking was:
json
emit modeIIRC, using
--message-format short
withclippy
lists the file names along with the line numbers with lint violations, but I didn't think trying to include line numbers made as much sense for rustfmt in theshort
mode.Each of these output/message formats is already available via other flags/options that have been recently added (
--emit json
,-l
,--files-with-diff
), so the implementation is basically just mapping the--message-format
value to those corresponding args rustfmt already supports.As examples:
short
json
(pretty printed after for ease of view)