-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rustc-ap-* crates to version 706 #4694
Conversation
Thank you for the PR! Is there any particular motivation behind this bump? I ask because we've been battling these crates for going on two weeks now, with rustfmt being broken on nightly throughout (rust-lang/rust#81583). We've quite literally just managed to get this sorted earlier today, so my bandwidth (and frankly appetite) for starting this all over again is pretty low. |
Yes. Release 706 includes a fix to make rustfmt compile on wasm32-unknown-unknown. Without the fix, rustc runs into an ICE: dprint/dprint-plugin-rustfmt#4 I don't know how high up the support for wasm32 is on the priority list so I'll leave this up to you! |
It's extremely low. Will certainly go ahead merge this, but not going to restart the crate update dance here til next week at the earliest. If you want to try to accelerate things, would encourage going ahead and opening the PR to bump these in racer as well. |
And given previous discussions I understand that your immediate goal is getting these changes for dprint specifically, but for any rustc-ap crate changes we need to go through the full cycle. For reference, here's what would need to be done in this case:
|
Thank you for writing these up, I'll have a go at trying to assist :) |
@calebcartwright I've opened a PR to racer and backported the change to the 1.4.37 branch. I don't think a release to crates.io is pressing for racer. From what I understand, it is for now good enough if these versions are simply kept in sync. A release of rustfmt 1.4.37 is also not pressing from my side. I am happy to depend on a specific commit for now :) |
A local
cargo check --all-targets
did not emit any errors so let's see what CI thinks.