-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidating dependencies #6034
Consolidating dependencies #6034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We link to dirs in Configurations.md. Can you also update the link? I haven't had a chance to review these dependency updates yet, but I'll follow up once I do.
The dirs bumpt to 5.0.1 looks good. There don't seem to be any updates that would break us as no changes were made to the @michaelciraci any chance you know where I can find out what changed with |
Hmm, yeah you're right. I started going through it, but there's quite a few changes. Is there something in particular you're looking for? |
Any changes to how We use it in Lines 531 to 549 in cedb7b5
|
We should be fine to upgrade. There are several internal changes (such as using The complete diff is here if you'd like to dig into the details yourself: oli-obk/cargo_metadata@0.15.0...0.18.1 |
c93f90d
to
391bb22
Compare
@michaelciraci thank you very much for taking the time to review those changes. It was a huge help not to have to go through it all myself 🙏🏼. This is next on my list to merge (just waiting on CI). |
Solve #6033
r? @ytmimi