Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustlings watch does nothing when all exercises are complete #251

Closed
codehearts opened this issue Dec 19, 2019 · 1 comment · Fixed by #253
Closed

rustlings watch does nothing when all exercises are complete #251

codehearts opened this issue Dec 19, 2019 · 1 comment · Fixed by #253
Labels
A-source Area: CLI source C-feature-request Category: Feature Request

Comments

@codehearts
Copy link
Contributor

I just completed everything in 2.1.0 and rustlings watch showed that my threads1 solution compiled, but no other output was shown. I assumed my solution was running but hit a deadlock or something, but 15 minutes later I realized watch does nothing when you're done

It'd be nice to display a congratulatory message so we can feel accomplished and know when we're done! 😸
@shadows-withal shadows-withal added A-source Area: CLI source C-feature-request Category: Feature Request labels Dec 19, 2019
@AbdouSeck
Copy link
Contributor

@codehearts this could be a very good feature, indeed. If you want to implement it, go for it. It's fairly manageable.
If you don't know where to start because you're not familiar with the project, I am happy to point you in the right direction and work with you to get it done. Let me know what you think.

Thanks,

Abdou

@codehearts codehearts mentioned this issue Dec 22, 2019
Merged
bors added a commit that referenced this issue Dec 28, 2019
@bors
Auto merge of #253 - codehearts:watch-completion-message, r=fmoko
0d1f1a1 
feat: Show a completion message when watching

The completion message is shown only once all exercises succeed and are
not annotated with "I AM NOT DONE." The watch command will also exit

closes #251

Let me know if there are any tests I could add or if the completion message should be tweaked!
@bors bors closed this as completed in d25ee55 Dec 28, 2019
pedantic79 pushed a commit to pedantic79/rustlings that referenced this issue Apr 11, 2020
@codehearts
feat: Show a completion message when watching
27f9952 
The completion message is shown only once all exercises succeed and are
not annotated with "I AM NOT DONE." The watch command will also exit

closes rust-lang#251
pedantic79 pushed a commit to pedantic79/rustlings that referenced this issue Apr 11, 2020
@bors
Auto merge of rust-lang#253 - codehearts:watch-completion-message, r=…
c09da2a 
…fmoko

feat: Show a completion message when watching

The completion message is shown only once all exercises succeed and are
not annotated with "I AM NOT DONE." The watch command will also exit

closes rust-lang#251

Let me know if there are any tests I could add or if the completion message should be tweaked!
MendelMonteiro pushed a commit to MendelMonteiro/rustlings that referenced this issue Jun 28, 2020
@codehearts @MendelMonteiro
feat: Show a completion message when watching
01f05cc 
The completion message is shown only once all exercises succeed and are
not annotated with "I AM NOT DONE." The watch command will also exit

closes rust-lang#251
ppp3 pushed a commit to ppp3/rustlings that referenced this issue May 23, 2022
feat: Show a completion message when watching
f903db8 
The completion message is shown only once all exercises succeed and are
not annotated with "I AM NOT DONE." The watch command will also exit

closes rust-lang#251
ppp3 pushed a commit to ppp3/rustlings that referenced this issue May 23, 2022
Auto merge of rust-lang#253 - codehearts:watch-completion-message, r=…
063bcb0 
…fmoko

feat: Show a completion message when watching

The completion message is shown only once all exercises succeed and are
not annotated with "I AM NOT DONE." The watch command will also exit

closes rust-lang#251

Let me know if there are any tests I could add or if the completion message should be tweaked!
dmoore04 pushed a commit to dmoore04/rustlings that referenced this issue Sep 11, 2022
@codehearts
feat: Show a completion message when watching
c3faa0d 
The completion message is shown only once all exercises succeed and are
not annotated with "I AM NOT DONE." The watch command will also exit

closes rust-lang#251
dmoore04 pushed a commit to dmoore04/rustlings that referenced this issue Sep 11, 2022
@bors
Auto merge of rust-lang#253 - codehearts:watch-completion-message, r=…
d0e118d 
…fmoko

feat: Show a completion message when watching

The completion message is shown only once all exercises succeed and are
not annotated with "I AM NOT DONE." The watch command will also exit

closes rust-lang#251

Let me know if there are any tests I could add or if the completion message should be tweaked!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-source Area: CLI source C-feature-request Category: Feature Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Show a completion message when watching
3 participants
@codehearts @shadows-withal @AbdouSeck