Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(watch): show hint while watching #241

Merged
merged 1 commit into from
Nov 18, 2019
Merged

feat(watch): show hint while watching #241

merged 1 commit into from
Nov 18, 2019

Conversation

vyaslav
Copy link
Contributor

@vyaslav vyaslav commented Nov 18, 2019

rustlings hint ... command is not convenient when doing exercises with rustlings watch.
This PR makes it possible for user to type hint while running watch and get hint text for exercise which is currently failing.
e.g.

...
  --> exercises/variables/variables1.rs:13:36
   |
13 |     println!("x has the value {}", x);
   |                                    ^ not found in this scope

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0425`.

type 'hint' to get help:
hint
Hint: The declaration on line 12 is missing a keyword that is needed in Rust
to create a new variable binding.

shadows-withal
shadows-withal reviewed Nov 18, 2019
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Show resolved Hide resolved
@shadows-withal
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 18, 2019

📌 Commit 8143d57 has been approved by fmoko

@bors
Copy link
Contributor

bors commented Nov 18, 2019

⌛ Testing commit 8143d57 with merge f4acb88...

bors added a commit that referenced this pull request Nov 18, 2019
@bors
Auto merge of #241 - vyaslav:master, r=fmoko
f4acb88 
feat(watch): show hint while watching

`rustlings hint ...` command is not convenient when doing exercises with `rustlings watch`.
This PR makes it possible for user to type `hint` while running `watch`  and get hint text for exercise which is currently failing.
e.g.
```rust
...
  --> exercises/variables/variables1.rs:13:36
   |
13 |     println!("x has the value {}", x);
   |                                    ^ not found in this scope

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0425`.

type 'hint' to get help:
hint
Hint: The declaration on line 12 is missing a keyword that is needed in Rust
to create a new variable binding.
```
@bors
Copy link
Contributor

bors commented Nov 18, 2019

☀️ Test successful - checks-travis
Approved by: fmoko
Pushing f4acb88 to master...

@bors bors merged commit 8143d57 into rust-lang:master Nov 18, 2019
pedantic79 pushed a commit to pedantic79/rustlings that referenced this pull request Apr 11, 2020
@bors
Auto merge of rust-lang#241 - vyaslav:master, r=fmoko
75389be 
feat(watch): show hint while watching

`rustlings hint ...` command is not convenient when doing exercises with `rustlings watch`.
This PR makes it possible for user to type `hint` while running `watch`  and get hint text for exercise which is currently failing.
e.g.
```rust
...
  --> exercises/variables/variables1.rs:13:36
   |
13 |     println!("x has the value {}", x);
   |                                    ^ not found in this scope

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0425`.

type 'hint' to get help:
hint
Hint: The declaration on line 12 is missing a keyword that is needed in Rust
to create a new variable binding.
```
ppp3 pushed a commit to ppp3/rustlings that referenced this pull request May 23, 2022
Auto merge of rust-lang#241 - vyaslav:master, r=fmoko
79aa062 
feat(watch): show hint while watching

`rustlings hint ...` command is not convenient when doing exercises with `rustlings watch`.
This PR makes it possible for user to type `hint` while running `watch`  and get hint text for exercise which is currently failing.
e.g.
```rust
...
  --> exercises/variables/variables1.rs:13:36
   |
13 |     println!("x has the value {}", x);
   |                                    ^ not found in this scope

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0425`.

type 'hint' to get help:
hint
Hint: The declaration on line 12 is missing a keyword that is needed in Rust
to create a new variable binding.
```
dmoore04 pushed a commit to dmoore04/rustlings that referenced this pull request Sep 11, 2022
@bors
Auto merge of rust-lang#241 - vyaslav:master, r=fmoko
2b22949 
feat(watch): show hint while watching

`rustlings hint ...` command is not convenient when doing exercises with `rustlings watch`.
This PR makes it possible for user to type `hint` while running `watch`  and get hint text for exercise which is currently failing.
e.g.
```rust
...
  --> exercises/variables/variables1.rs:13:36
   |
13 |     println!("x has the value {}", x);
   |                                    ^ not found in this scope

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0425`.

type 'hint' to get help:
hint
Hint: The declaration on line 12 is missing a keyword that is needed in Rust
to create a new variable binding.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadows-withal shadows-withal shadows-withal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyaslav @shadows-withal @bors