feat: Remind the user of the hint option #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggestion from AbdouSeck rust-lang#424 (comment) for when the student's code has errors.
AbdouSeck
approved these changes
Jun 13, 2020
There was a problem hiding this comment.
This change should catch exercises where the code compiles but the output panics. One caveat with this patch is that it only makes the learner aware that their code panics. It does not mark the exercise as incomplete. I cannot currently think of an easy way to force panicking code to be marked as incomplete when the exercise is not a Test exercise. But there should be a way to get that done.
For now, though, I would approve this and hopefully we'll engage in more discussion to see if there is any merit to marking a Compile mode exercise as incomplete if the learner's code panics.
Thanks!
Abdou
shadows-withal
approved these changes
Jul 8, 2020
shadows-withal
changed the title
shadows-withal
pushed a commit
that referenced
this pull request
Jul 8, 2020
Suggestion from AbdouSeck #424 (comment) for when the student's code has errors.
dlemel8
pushed a commit
to dlemel8/rustlings
that referenced
this pull request
Aug 2, 2020
Suggestion from AbdouSeck rust-lang#424 (comment) for when the student's code has errors.
ppp3
pushed a commit
to ppp3/rustlings
that referenced
this pull request
May 23, 2022
Suggestion from AbdouSeck rust-lang#424 (comment) for when the student's code has errors.
ppp3
pushed a commit
to ppp3/rustlings
that referenced
this pull request
May 23, 2022
Suggestion from AbdouSeck rust-lang#424 (comment) for when the student's code has errors.
dmoore04
pushed a commit
to dmoore04/rustlings
that referenced
this pull request
Sep 11, 2022
Suggestion from AbdouSeck rust-lang#424 (comment) for when the student's code has errors.
dmoore04
pushed a commit
to dmoore04/rustlings
that referenced
this pull request
Sep 11, 2022
Suggestion from AbdouSeck rust-lang#424 (comment) for when the student's code has errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion from AbdouSeck #424 (comment) for when the student's code has errors.
(Works for me, but I haven't done extensive testing to check how this could impact other exercises, so this should be reviewed by someone more competent than me, before merging.)