Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add detail to arc1.rs comment and hint message #710

Merged
merged 5 commits into from
Apr 21, 2021
Merged

add detail to arc1.rs comment and hint message #710

merged 5 commits into from
Apr 21, 2021

Conversation

bmacer
Copy link
Contributor

@bmacer bmacer commented Apr 20, 2021

Adds an explanation to exercises/standard_library_types/arc1.rs to hopefully alleviate some confusion around this exercise. Hopefully sufficient to close #250.

@bmacer bmacer mentioned this pull request Apr 20, 2021
Closed
shadows-withal
shadows-withal reviewed Apr 20, 2021
View reviewed changes
Copy link
Member

@shadows-withal shadows-withal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! I think this is a great step in the right direction :) I added some stylistic pointers, and I'll have someone else look over it before we merge it, but this looks really good to me.

exercises/standard_library_types/arc1.rs Outdated Show resolved Hide resolved
exercises/standard_library_types/arc1.rs Outdated Show resolved Hide resolved
exercises/standard_library_types/arc1.rs Outdated Show resolved Hide resolved
bmacer and others added 3 commits April 20, 2021 08:23
@bmacer @shadows-withal
Update exercises/standard_library_types/arc1.rs
a070baa 
Co-authored-by: marisa <mokou@fastmail.com>
@bmacer @shadows-withal
Update exercises/standard_library_types/arc1.rs
037f916 
Co-authored-by: marisa <mokou@fastmail.com>
@bmacer @shadows-withal
Update exercises/standard_library_types/arc1.rs
24e0a6a 
Co-authored-by: marisa <mokou@fastmail.com>
jrvidal
jrvidal approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@jrvidal jrvidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor nit

exercises/standard_library_types/arc1.rs Outdated Show resolved Hide resolved
@shadows-withal @jrvidal
Update exercises/standard_library_types/arc1.rs
870ef58 
Co-authored-by: Roberto Vidal <vidal.roberto.j@gmail.com>
@shadows-withal shadows-withal merged commit 81be404 into rust-lang:main Apr 21, 2021
@shadows-withal
Copy link
Member

@all-contributors please add @bmacer for content

@allcontributors allcontributors bot mentioned this pull request Apr 21, 2021
Merged
@allcontributors
Copy link
Contributor

@fmoko

I've put up a pull request to add @bmacer! 🎉

ingrachen pushed a commit to ingrachen/rustlings that referenced this pull request May 2, 2021
@bmacer @shadows-withal
@jrvidal @ingrachen
feat(arc1): Add more details to description and hint (rust-lang#710)
5f2a506 
Co-authored-by: bmacer <bmacer@cisco.com>
Co-authored-by: marisa <mokou@fastmail.com>
Co-authored-by: Roberto Vidal <vidal.roberto.j@gmail.com>
wh5a pushed a commit to wh5a/rustlings-solutions that referenced this pull request May 4, 2021
Merge remote-tracking branch 'upstream/main' into main
4af613f 
* upstream/main: (38 commits)
  docs: update .all-contributorsrc [skip ci]
  docs: update README.md [skip ci]
  style(standard_library_types): stray line break
  chore: Update quiz1.rs add explicit test for 40
  docs: update .all-contributorsrc [skip ci]
  docs: update README.md [skip ci]
  updated README.md; specify need for admin rights
  release: 4.4.0
  chore(watch): add hint for the exercises README.md
  chore(deps): update cargo dependencies
  docs(exercises): updated all exercises readme files
  docs(generics): add bounds help
  docs(errors): add additional help for Result/Boxing
  fix(main): Let find_exercise work with borrows
  docs: update .all-contributorsrc [skip ci]
  docs: update README.md [skip ci]
  feat(arc1): Add more details to description and hint (rust-lang#710)
  chore: Fix integration tests
  feat: Replace clap with argh
  Improved iterators5.rs explanation.
  ...
liangminhua pushed a commit to liangminhua/rustlings that referenced this pull request Jul 10, 2021
@bmacer @shadows-withal
@jrvidal @liangminhua
feat(arc1): Add more details to description and hint (rust-lang#710)
154aa91 
Co-authored-by: bmacer <bmacer@cisco.com>
Co-authored-by: marisa <mokou@fastmail.com>
Co-authored-by: Roberto Vidal <vidal.roberto.j@gmail.com>
noiffion pushed a commit to noiffion/rustlings that referenced this pull request Aug 20, 2021
@bmacer @shadows-withal
@jrvidal @noiffion
feat(arc1): Add more details to description and hint (rust-lang#710)
6f0b687 
Co-authored-by: bmacer <bmacer@cisco.com>
Co-authored-by: marisa <mokou@fastmail.com>
Co-authored-by: Roberto Vidal <vidal.roberto.j@gmail.com>
bugaolengdeyuxiaoer pushed a commit to bugaolengdeyuxiaoer/rustlings that referenced this pull request Dec 28, 2021
@bmacer @shadows-withal @jrvidal
feat(arc1): Add more details to description and hint (rust-lang#710)
8007f38 
Co-authored-by: bmacer <bmacer@cisco.com>
Co-authored-by: marisa <mokou@fastmail.com>
Co-authored-by: Roberto Vidal <vidal.roberto.j@gmail.com>
ppp3 pushed a commit to ppp3/rustlings that referenced this pull request May 23, 2022
@bmacer @shadows-withal @jrvidal
feat(arc1): Add more details to description and hint (rust-lang#710)
4b084f1 
Co-authored-by: bmacer <bmacer@cisco.com>
Co-authored-by: marisa <mokou@fastmail.com>
Co-authored-by: Roberto Vidal <vidal.roberto.j@gmail.com>
dmoore04 pushed a commit to dmoore04/rustlings that referenced this pull request Sep 11, 2022
@bmacer @shadows-withal @jrvidal
feat(arc1): Add more details to description and hint (rust-lang#710)
41dfe97 
Co-authored-by: bmacer <bmacer@cisco.com>
Co-authored-by: marisa <mokou@fastmail.com>
Co-authored-by: Roberto Vidal <vidal.roberto.j@gmail.com>
Spacebody pushed a commit to Spacebody/my-rustlings that referenced this pull request Nov 18, 2022
@bmacer @shadows-withal
@jrvidal @Spacebody
feat(arc1): Add more details to description and hint (rust-lang#710)
122511e 
Co-authored-by: bmacer <bmacer@cisco.com>
Co-authored-by: marisa <mokou@fastmail.com>
Co-authored-by: Roberto Vidal <vidal.roberto.j@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadows-withal shadows-withal shadows-withal left review comments

@jrvidal jrvidal jrvidal approved these changes

@AbdouSeck AbdouSeck Awaiting requested review from AbdouSeck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

arc1 seems like a giant step
3 participants
@bmacer @shadows-withal @jrvidal