do not get cwd if not env set

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
rust-lang · Mar 18, 2018 · 3c7726c · 3c7726c
1 parent cc87d74
commit 3c7726c
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 8 deletions.
diff --git a/src/rustup-utils/src/errors.rs b/src/rustup-utils/src/errors.rs
@@ -156,6 +156,9 @@ error_chain! {
             description("failed to set permissions")
             display("failed to set permissions for '{}'", path.display())
         }
+        GettingCwd {
+            description("couldn't get current working directory")
+        }
         CargoHome {
             description("couldn't find value of CARGO_HOME")
         }

diff --git a/src/rustup-utils/src/utils.rs b/src/rustup-utils/src/utils.rs
@@ -546,10 +546,15 @@ pub fn cargo_home() -> Result<PathBuf> {
         None
     };
 
-    let cwd = try!(env::current_dir().chain_err(|| ErrorKind::CargoHome));
-    let cargo_home = env_var.clone().map(|home| {
-        cwd.join(home)
-    });
+    let cargo_home = if env_var.is_some() {
+        let cwd = try!(env::current_dir().chain_err(|| ErrorKind::GettingCwd));
+        env_var.clone().map(|home| {
+            cwd.join(home)
+        })
+    } else {
+        None
+    };
+
     let user_home = home_dir().map(|p| p.join(".cargo"));
     cargo_home.or(user_home).ok_or(ErrorKind::CargoHome.into())
 }
@@ -739,11 +744,17 @@ pub fn rustup_home_in_user_dir() -> Result<PathBuf> {
 
 pub fn rustup_home() -> Result<PathBuf> {
     let use_rustup_dir = do_rustup_home_upgrade();
+    let rustup_home_env = env::var_os("RUSTUP_HOME");
+
+    let rustup_home = if rustup_home_env.is_some() {
+        let cwd = try!(env::current_dir().chain_err(|| ErrorKind::GettingCwd));
+        rustup_home_env.clone().map(|home| {
+            cwd.join(home)
+        })
+    } else {
+        None
+    };
 
-    let cwd = try!(env::current_dir().chain_err(|| ErrorKind::RustupHome));
-    let rustup_home = env::var_os("RUSTUP_HOME").map(|home| {
-        cwd.join(home)
-    });
     let user_home = if use_rustup_dir {
         dot_dir(".rustup")
     } else {
@@ -836,6 +847,18 @@ pub fn toolchain_sort<T: AsRef<str>>(v: &mut Vec<T>) {
 mod tests {
     use super::*;
 
+    #[test]
+    fn test_cargo_home() {
+        // CARGO_HOME unset, we'll get the default ending in /.cargo
+        let cargo_home1 = cargo_home();
+        let ch = format!("{}", cargo_home1.unwrap().display());
+        assert!(ch.contains("/.cargo"));
+
+        env::set_var("CARGO_HOME", "/test");
+        let cargo_home2 = cargo_home();
+        assert_eq!("/test", format!("{}", cargo_home2.unwrap().display()));
+    }
+
     #[test]
     fn test_toochain_sort() {
         let expected = vec![