Merge pull request #2993 from kinnison/fix-2982

(toolchain): Toolchain names must not be empty
rust-lang · Oct 6, 2022 · e40ca12 · e40ca12
2 parents f94717b + ce4027a
commit e40ca12
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/src/config.rs b/src/config.rs
@@ -457,6 +457,10 @@ impl Cfg {
             })?;
         }
 
+        if name.is_empty() {
+            anyhow::bail!("toolchain names must not be empty");
+        }
+
         Toolchain::from(self, name)
     }
 

diff --git a/tests/cli-v2.rs b/tests/cli-v2.rs
@@ -842,6 +842,19 @@ fn add_target_custom_toolchain() {
     });
 }
 
+#[test]
+fn cannot_add_empty_named_custom_toolchain() {
+    setup(&|config| {
+        let path = config.customdir.join("custom-1");
+        let path = path.to_string_lossy();
+        expect_err(
+            config,
+            &["rustup", "toolchain", "link", "", &path],
+            "toolchain names must not be empty",
+        );
+    });
+}
+
 #[test]
 fn add_target_again() {
     setup(&|config| {