Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZDOTDIR not obeyed when installing to .zprofile #1036

Closed
Nemo157 opened this issue Apr 6, 2017 · 0 comments
Closed

ZDOTDIR not obeyed when installing to .zprofile #1036

Nemo157 opened this issue Apr 6, 2017 · 0 comments

Comments

@Nemo157
Copy link
Member

Nemo157 commented Apr 6, 2017

If the shell is a login shell, commands are read from /etc/zprofile and then $ZDOTDIR/.zprofile.
If ZDOTDIR is unset, HOME is used instead.
— man zsh

Currently https://github.com/rust-lang-nursery/rustup.rs/blob/904ecf0a97b508f929233280644592d90cf9e2c5/src/rustup-cli/self_update.rs#L984 just installs to $HOME/.zprofile, this should check if ZDOTDIR is set and use that instead.
Nemo157 added a commit to Nemo157/rustup.rs that referenced this issue Apr 6, 2017
@Nemo157
Check ZDOTDIR when adding path to .zprofile
ae7173f 
Fixes rust-lang#1036
@Nemo157 Nemo157 mentioned this issue Apr 6, 2017
Merged
bors added a commit that referenced this issue Apr 8, 2017
@bors
Auto merge of #1038 - Nemo157:zdotdir, r=brson
cf2d6a3 
Check ZDOTDIR when adding path to .zprofile

Fixes #1036
nodakai pushed a commit to nodakai/rustup.rs that referenced this issue Apr 23, 2017
@Nemo157 @nodakai
Check ZDOTDIR when adding path to .zprofile
8b6fa49 
Fixes rust-lang#1036
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Nemo157