Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove_override_nonexistent test is flaky on windows #1103

Open
brson opened this issue May 8, 2017 · 1 comment
Open

remove_override_nonexistent test is flaky on windows #1103

brson opened this issue May 8, 2017 · 1 comment
Labels
bug

Comments

@brson
Copy link
Contributor

brson commented May 8, 2017

It might be because of TempDir failing to delete the directory. Upgrading to a tempdir that contains the aggressive remove_dir_all patch could fix it.

cc #1102
@brson brson added the bug label May 8, 2017
brson added a commit to brson/rustup.rs that referenced this issue May 9, 2017
@brson
Ignore remove_override_nonexistent on windows. rust-lang#1103
9d07e26
brson added a commit to brson/rustup.rs that referenced this issue May 9, 2017
@brson
Ignore remove_override_nonexistent on windows. rust-lang#1103
aecf914
bors added a commit that referenced this issue May 10, 2017
@bors
Auto merge of #1105 - brson:ignore, r=Diggsey
aa03bc1 
Ignore remove_override_nonexistent on windows. #1103

r? @Diggsey
@brson brson mentioned this issue May 12, 2017
Closed
@mattico mattico mentioned this issue May 12, 2017
Merged
@brson
Copy link
Contributor Author

brson commented Jun 9, 2017

tempdir has been updated, but no new build published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brson