Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to install the toolchain specified in the override file #1218

Closed
shinglyu opened this issue Jul 31, 2017 · 3 comments
Closed

Add a way to install the toolchain specified in the override file #1218

shinglyu opened this issue Jul 31, 2017 · 3 comments

Comments

@shinglyu
Copy link

#1172 allows us to create a rust-toolchain file and specify a version of the toolchain to be used in the current directory. But I can't seem to find a way to install the specified version automatically.
Now I do cat rust-toolchain | xargs rustup install, but it would be nice to have a command like rustup install rust-toolchain or maybe simply rustup install (fail if the file is not present).

Thoughts? @brson

@paulrouget
Copy link

As of now, what happens exactly when the toolchain version is not available? Just fail or fallback to the closest toolchain?

@paulrouget
Copy link

Just fail.

@shinglyu
Copy link
Author

Oh sorry for missing this. Yes it just failed with a warning saying the version didn't match

SimonSapin added a commit to SimonSapin/rustup.rs that referenced this issue Sep 12, 2017
A typical scenario is:

* I work on a repository that uses `rust-toolchain` to pin to a specific Nightly version
* I run `git pull`, `rust-toolchain` has been changed to update to a new Rust version
* I run `cargo build`

Result before this PR (typically): rustup fails with an error like:

```
error: override toolchain 'nightly-2017-08-31' is not installed
info: caused by: the toolchain file at '/home/simon/projects/servo/rust-toolchain' specifies an uninstalled toolchain
```

A better result would be to install toolchains as needed.

Closes rust-lang#1218
SimonSapin added a commit to SimonSapin/rustup.rs that referenced this issue Sep 12, 2017
A typical scenario is:

* I work on a repository that uses `rust-toolchain` to pin to a specific Nightly version
* I run `git pull`, `rust-toolchain` has been changed to update to a new Rust version
* I run `cargo build`

Result before this PR (typically): rustup fails with an error like:

```
error: override toolchain 'nightly-2017-08-31' is not installed
info: caused by: the toolchain file at '/home/simon/projects/servo/rust-toolchain' specifies an uninstalled toolchain
```

A better result would be to install toolchains as needed.

Closes rust-lang#1218
SimonSapin added a commit to SimonSapin/rustup.rs that referenced this issue Oct 16, 2017
A typical scenario is:

* I work on a repository that uses `rust-toolchain` to pin to a specific Nightly version
* I run `git pull`, `rust-toolchain` has been changed to update to a new Rust version
* I run `cargo build`

Result before this PR (typically): rustup fails with an error like:

```
error: override toolchain 'nightly-2017-08-31' is not installed
info: caused by: the toolchain file at '/home/simon/projects/servo/rust-toolchain' specifies an uninstalled toolchain
```

A better result would be to install toolchains as needed.

Closes rust-lang#1218
bors added a commit that referenced this issue Oct 16, 2017
Automatically install override toolchain when missing.

A typical scenario is:

* I work on a repository that uses `rust-toolchain` to pin to a specific Nightly version
* I run `git pull`, `rust-toolchain` has been changed to update to a new Rust version
* I run `cargo build`

Result before this PR (typically): rustup fails with an error like:

```
error: override toolchain 'nightly-2017-08-31' is not installed
info: caused by: the toolchain file at '/home/simon/projects/servo/rust-toolchain' specifies an uninstalled toolchain
```

A better result would be to automatically install toolchains as needed.

Closes #1218
mattico pushed a commit to mattico/rustup.rs that referenced this issue Apr 5, 2018
A typical scenario is:

* I work on a repository that uses `rust-toolchain` to pin to a specific Nightly version
* I run `git pull`, `rust-toolchain` has been changed to update to a new Rust version
* I run `cargo build`

Result before this PR (typically): rustup fails with an error like:

```
error: override toolchain 'nightly-2017-08-31' is not installed
info: caused by: the toolchain file at '/home/simon/projects/servo/rust-toolchain' specifies an uninstalled toolchain
```

A better result would be to install toolchains as needed.

Closes rust-lang#1218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants