Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open_browser broken on linux #17

Closed
crumblingstatue opened this issue Oct 23, 2015 · 2 comments
Closed

open_browser broken on linux #17

crumblingstatue opened this issue Oct 23, 2015 · 2 comments

Comments

@crumblingstatue
Copy link
Contributor

The not(windows) implementation of open_browser uses command to see whether a command exists, but command is a shell-builtin (at least in bash), so it doesn't work when invoked through process::Command.

How about instead using the which command?
@crumblingstatue
Copy link
Contributor Author

To put it in context, this renders multirust doc unusable, which is a feature I often used in the shell-script version.

@Diggsey
Copy link
Contributor

Diggsey commented Oct 23, 2015

Thanks for reporting this: it's now fixed and new binaries have been uploaded.

@Diggsey Diggsey closed this as completed Oct 23, 2015
@erde74 erde74 mentioned this issue Aug 15, 2016
Closed
djc added a commit that referenced this issue Jun 18, 2024
@djc
# This is a combination of 40 commits.
97dd0be 
# This is the 1st commit message:

Port cli_inst_interactive to CliTestContext

# The commit message #2 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #3 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #4 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #5 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #6 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #7 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #8 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #9 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #10 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #11 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #12 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #13 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #14 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #15 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #16 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #17 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #18 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #19 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #20 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #21 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #22 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #23 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #24 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #25 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #26 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #27 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #28 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #29 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #30 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #31 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #32 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #33 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #34 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #35 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #36 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #37 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #38 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #39 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #40 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext
djc added a commit that referenced this issue Jun 18, 2024
@djc
# This is a combination of 19 commits.
f9d90a3 
# This is the 1st commit message:

Port cli_misc to CliTestContext

# The commit message #2 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #3 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #4 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #5 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #6 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #7 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #8 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #9 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #10 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #11 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #12 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #13 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #14 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #15 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #16 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #17 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #18 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #19 will be skipped:

# fixup! Port cli_misc to CliTestContext
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Diggsey @crumblingstatue