Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide help if user attempts to install 1.0 through 1.8 since those need 1.0.0 through 1.8.0 #2621

Closed
jyn514 opened this issue Dec 26, 2020 · 6 comments · Fixed by #2758
Closed

Comments

@jyn514
Copy link
Member

jyn514 commented Dec 26, 2020

Problem

rustup install 1.0 should install 1.0.0, the same way that rustup install 1.48 installs 1.48.0. Instead it gives an error.

Steps

  1. rustup install 1.0
error: could not download nonexistent rust version `1.0-x86_64-unknown-linux-gnu`
error: caused by: could not download file from 'https://static.rust-lang.org/dist/rust-1.0-x86_64-unknown-linux-gnu.tar.gz.sha256' to '/home/joshua/.local/lib/rustup/tmp/6491fh929v2mgx7y_file'
error: caused by: http request returned an unsuccessful status code: 404

This looks like a problem on T-infra's side? But I'm not sure what's going wrong, so I'm dumping it on you instead :P

Notes

Output of rustup --version: rustup 1.23.1 (3df2264 2020-11-30)

@jyn514 jyn514 added the bug label Dec 26, 2020
@kinnison kinnison added not-rustup Whatever is described in this issue isn't Rustup's fault question and removed bug labels Dec 28, 2020
@kinnison
Copy link
Contributor

This is not rustup's fault. We've not generated 1.x manifest links for toolchains before manifest version 2 came out. If we were to do this, it would require retrogenerating v2 manifests for the older toolchains which while possible (and possibly desirable) would be rewriting history to some extent.

Either way this isn't rustup's problem. I'll leave this open for now until someone involved in the 1.x manifest work can weigh in though. Perhaps @pietroalbini or @carols10cents ?

@pietroalbini
Copy link
Member

How hard would it be to just hardcode that there were no point releases for manifest v1 releases?

@kinnison
Copy link
Contributor

rustup doesn't know for sure which releases are v1 or v2, it just tries v2 and falls back to v1 if it can't find it. I suppose it could then try falling back to a v1 without the point release, but that starts to feel icky IMO.

@jyn514
Copy link
Member Author

jyn514 commented Apr 25, 2021

I suppose it could then try falling back to a v1 without the point release, but that starts to feel icky IMO.

Would it make sense to do this, but only as a warning? "help: did you mean rustup toolchain install 1.0.0"?

@kinnison kinnison added E-easy E-mentor enhancement help wanted and removed not-rustup Whatever is described in this issue isn't Rustup's fault question labels Apr 29, 2021
@kinnison
Copy link
Contributor

I think that would be acceptable. Yes. I'll retitle the issue.

if someone wishes to tackle this, it should be fairly easy to complete.

@kinnison kinnison changed the title rustup install 1.0 does not work Provide help if user attempts to install 1.0 through 1.8 since those need 1.0.0 through 1.8.0 Apr 29, 2021
@carols10cents
Copy link
Member

Hm, I think if I typed rustup toolchain install 1.0 after being used to typing rustup toolchain install 1.50 and rustup said help: did you mean rustup toolchain install 1.0.0 I would be sad and angry.

carols10cents added a commit to integer32llc/rustup.rs that referenced this issue May 7, 2021
Because these versions don't have v2 manifests available.

Fixes rust-lang#2621.
rbtcollins pushed a commit to rbtcollins/rustup.rs that referenced this issue Jul 11, 2021
Because these versions don't have v2 manifests available.

Fixes rust-lang#2621.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants