-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide help if user attempts to install 1.0
through 1.8
since those need 1.0.0
through 1.8.0
#2621
Comments
This is not rustup's fault. We've not generated 1.x manifest links for toolchains before manifest version 2 came out. If we were to do this, it would require retrogenerating v2 manifests for the older toolchains which while possible (and possibly desirable) would be rewriting history to some extent. Either way this isn't rustup's problem. I'll leave this open for now until someone involved in the 1.x manifest work can weigh in though. Perhaps @pietroalbini or @carols10cents ? |
How hard would it be to just hardcode that there were no point releases for manifest v1 releases? |
rustup doesn't know for sure which releases are v1 or v2, it just tries v2 and falls back to v1 if it can't find it. I suppose it could then try falling back to a v1 without the point release, but that starts to feel icky IMO. |
Would it make sense to do this, but only as a warning? "help: did you mean |
I think that would be acceptable. Yes. I'll retitle the issue. if someone wishes to tackle this, it should be fairly easy to complete. |
1.0
through 1.8
since those need 1.0.0
through 1.8.0
Hm, I think if I typed |
Because these versions don't have v2 manifests available. Fixes rust-lang#2621.
Because these versions don't have v2 manifests available. Fixes rust-lang#2621.
Problem
rustup install 1.0
should install 1.0.0, the same way thatrustup install 1.48
installs 1.48.0. Instead it gives an error.Steps
rustup install 1.0
This looks like a problem on T-infra's side? But I'm not sure what's going wrong, so I'm dumping it on you instead :P
Notes
Output of
rustup --version
: rustup 1.23.1 (3df2264 2020-11-30)The text was updated successfully, but these errors were encountered: