Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify manifests so rust-docs are required again #903

Closed
brson opened this issue Jan 6, 2017 · 2 comments
Closed

Modify manifests so rust-docs are required again #903

brson opened this issue Jan 6, 2017 · 2 comments

Comments

@brson
Copy link
Contributor

brson commented Jan 6, 2017

It seems that most people are comforted knowing docs are available by default, so I want to turn them back on, then add some more options to remove them.

This needs to be done in rust-buildbot.

re https://users.rust-lang.org/t/psa-rust-documentation-is-now-optional-and-opt-in-when-installing-via-rustup/8072/21
@bmmoore
Copy link

bmmoore commented Mar 1, 2017 •
edited
Loading

It's not just a question of comfort! Until the rustup bug about trying to open missing docs (symptoms as #959 or #901), and the now-incorrect --help text is fixed (#891) it's a big hit to usability too. Please don't leave this broken.

@carols10cents carols10cents mentioned this issue Mar 6, 2017
Closed
@brson brson mentioned this issue Mar 14, 2017
Merged
@brson
Copy link
Contributor Author

brson commented Mar 14, 2017

Here's a patch rust-lang/rust#40526

frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40526 - brson:docs-req, r=alexcrichton
b90dd33 
Make docs required again

Completely untested. Fixes rust-lang/rustup#903

r? @alexcrichton cc @steveklabnik
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40526 - brson:docs-req, r=alexcrichton
7a6ee75 
Make docs required again

Completely untested. Fixes rust-lang/rustup#903

r? @alexcrichton cc @steveklabnik
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40526 - brson:docs-req, r=alexcrichton
0ae763d 
Make docs required again

Completely untested. Fixes rust-lang/rustup#903

r? @alexcrichton cc @steveklabnik
frewsxcv added a commit to frewsxcv/rust that referenced this issue Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40526 - brson:docs-req, r=alexcrichton
11788ea 
Make docs required again

Completely untested. Fixes rust-lang/rustup#903

r? @alexcrichton cc @steveklabnik
bors added a commit to rust-lang/rust that referenced this issue Mar 17, 2017
@bors
Auto merge of #40526 - brson:docs-req, r=alexcrichton
b3234cd 
Make docs required again

Completely untested. Fixes rust-lang/rustup#903

r? @alexcrichton cc @steveklabnik
@MJDSys MJDSys mentioned this issue Mar 20, 2017
Closed
3 tasks
This was referenced Nov 14, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brson @bmmoore