Aggressive remove_dir_all #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like we might need an aggressive |
|
I personally forget, but can you clarify how precisely this is more aggressive again? |
|
It moves the files out of the subdirectory and up next to the directory being deleted, prior to deleting them. This means if the file deletion is delayed due to outstanding locks, then the directories can still be deleted successfully without waiting for other processes to close their file handles. The failure here looks different - like a race condition in one of the self-updater tests possibly? |
|
Updated to fix the linux build hopefully. |
|
@bors r+ |
|
📌 Commit b61370a has been approved by |
bors
added a commit
that referenced
this pull request
Mar 31, 2017
Aggressive remove_dir_all Let's see if this helps the flakiness. cc @Diggsey @alexcrichton cc @Aaronepower this PR contains a self-contained remove_dir_all module based on winapi.
|
💔 Test failed - status-appveyor |
|
Test failure was network error and i want to deploy this in next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if this helps the flakiness.
cc @Diggsey @alexcrichton
cc @Aaronepower this PR contains a self-contained remove_dir_all module based on winapi.